Avoid using parsers for OPTIONS method.

RobinTail · May 7, 2024 · 9a3b21c · 9a3b21c
1 parent 81ec8a6
commit 9a3b21c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/routing.ts b/src/routing.ts
@@ -28,10 +28,11 @@ export const initRouting = ({
     routing,
     hasCors: !!config.cors,
     onEndpoint: (endpoint, path, method, siblingMethods) => {
-      // @todo skip for "options" method?
-      const middlewares = parsers?.[endpoint.getRequestType()] || [];
-      if (middlewares.length) {
-        app.use(path, middlewares);
+      if (method !== "options") {
+        const middlewares = parsers?.[endpoint.getRequestType()] || [];
+        if (middlewares.length) {
+          app.use(path, middlewares);
+        }
       }
       app[method](path, async (request, response) => {
         const logger = config.childLoggerProvider

diff --git a/tests/unit/server.spec.ts b/tests/unit/server.spec.ts
@@ -63,7 +63,7 @@ describe("Server", () => {
       await createServer(configMock, routingMock);
       expect(appMock).toBeTruthy();
       expect(appMock.disable).toHaveBeenCalledWith("x-powered-by");
-      expect(appMock.use).toHaveBeenCalledTimes(5);
+      expect(appMock.use).toHaveBeenCalledTimes(4);
       expect(appMock.use.mock.calls[0]).toEqual([
         "/v1/test",
         [expressJsonMock],
@@ -116,7 +116,7 @@ describe("Server", () => {
       expect(logger).toEqual(customLogger);
       expect(app).toEqual(appMock);
       expect(appMock).toBeTruthy();
-      expect(appMock.use).toHaveBeenCalledTimes(5);
+      expect(appMock.use).toHaveBeenCalledTimes(4);
       expect(appMock.use.mock.calls[0]).toEqual([
         "/v1/test",
         [configMock.server.jsonParser],
@@ -200,7 +200,7 @@ describe("Server", () => {
         },
       };
       await createServer(configMock, routingMock);
-      expect(appMock.use).toHaveBeenCalledTimes(5);
+      expect(appMock.use).toHaveBeenCalledTimes(4);
       expect(compressionMock).toHaveBeenCalledTimes(1);
       expect(compressionMock).toHaveBeenCalledWith(undefined);
     });
@@ -235,7 +235,7 @@ describe("Server", () => {
         },
       };
       await createServer(configMock, routingMock);
-      expect(appMock.use).toHaveBeenCalledTimes(4);
+      expect(appMock.use).toHaveBeenCalledTimes(3);
       expect(appMock.use.mock.calls[0]).toEqual([
         "/v1/test",
         [beforeUpload, uploader, expect.any(Function)], // 3rd: createUploadFailueHandler()
@@ -271,7 +271,7 @@ describe("Server", () => {
         },
       };
       await createServer(configMock, routingMock);
-      expect(appMock.use).toHaveBeenCalledTimes(4);
+      expect(appMock.use).toHaveBeenCalledTimes(3);
       expect(appMock.use.mock.calls[0]).toEqual([
         "/v1/test",
         [rawParserMock, rawMover],