Skip to content

Commit

Permalink
Fix typo in createUploadFailureHandler naming (#2002)
Browse files Browse the repository at this point in the history
  • Loading branch information
RobinTail committed Aug 24, 2024
1 parent 6c2add7 commit ded230b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/server-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const createNotFoundHandler =
}
};

export const createUploadFailueHandler =
export const createUploadFailureHandler =
(error: Error): RequestHandler =>
(req, {}, next) => {
const failedFile = Object.values(req?.files || [])
Expand Down Expand Up @@ -112,7 +112,7 @@ export const createUploadParsers = async ({
})(request, response, next);
});
if (limitError) {
parsers.push(createUploadFailueHandler(limitError));
parsers.push(createUploadFailureHandler(limitError));
}
return parsers;
};
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/server-helpers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { metaSymbol } from "../../src/metadata";
import {
createNotFoundHandler,
createParserFailureHandler,
createUploadFailueHandler,
createUploadFailureHandler,
createUploadLogger,
createUploadParsers,
moveRaw,
Expand Down Expand Up @@ -131,14 +131,14 @@ describe("Server helpers", () => {
});
});

describe("createUploadFailueHandler()", () => {
describe("createUploadFailureHandler()", () => {
const error = new Error("Too heavy");

test.each([
{ files: { one: { truncated: true } } },
{ files: { one: [{ truncated: false }, { truncated: true }] } },
])("should handle truncated files by calling next with error %#", (req) => {
const handler = createUploadFailueHandler(error);
const handler = createUploadFailureHandler(error);
const next = vi.fn();
handler(req as unknown as Request, makeResponseMock(), next);
expect(next).toHaveBeenCalledWith(error);
Expand All @@ -150,7 +150,7 @@ describe("Server helpers", () => {
{ files: { one: { truncated: false } } },
{ file: { one: [{ truncated: false }] } },
])("should call next when all uploads succeeded %#", (req) => {
const handler = createUploadFailueHandler(error);
const handler = createUploadFailureHandler(error);
const next = vi.fn();
handler(req as unknown as Request, makeResponseMock(), next);
expect(next).toHaveBeenCalledWith();
Expand Down

0 comments on commit ded230b

Please sign in to comment.