Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providing child logger to beforeRouting #1998

Merged
merged 21 commits into from
Aug 26, 2024
Merged

Providing child logger to beforeRouting #1998

merged 21 commits into from
Aug 26, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Aug 20, 2024 •
edited
Loading

According to discussion #1995

Other changes:

  • changed the way child logger is stored and extracted: via request.response, so that getChildLogger() method could accept request for more intuitive usage.

@RobinTail RobinTail added the enhancement New feature or request label Aug 20, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Aug 20, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 1132483 on feat-child-logger-before-routing
into c6ef89a on master.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Aug 24, 2024
@RobinTail RobinTail changed the title Exp: child logger for beforeRouting Child logger for beforeRouting Aug 24, 2024
@RobinTail RobinTail marked this pull request as ready for review August 24, 2024 08:58
RobinTail
RobinTail commented Aug 24, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@RobinTail RobinTail added the documentation Improvements or additions to documentation label Aug 24, 2024
@RobinTail RobinTail changed the title Child logger for beforeRouting Providing child logger to beforeRouting Aug 24, 2024
@RobinTail
Copy link
Owner Author

RobinTail commented Aug 24, 2024 •
edited
Loading

🚀 published 20.8.0-beta.1, waiting for a feedback from @williamgcampbell in #1995

@RobinTail
Copy link
Owner Author

✅ regression test passed

RobinTail
RobinTail commented Aug 26, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@RobinTail RobinTail merged commit afc63e9 into master Aug 26, 2024
11 checks passed
@RobinTail RobinTail deleted the feat-child-logger-before-routing branch August 26, 2024 06:19
@williamgcampbell
Copy link

Thanks @RobinTail !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinTail @williamgcampbell