[IMPROVE] Inappchat improvements and fixes #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging ab89eda into 8b32f11 - view on LGTM.com new alerts:
|
sidmohanty11
force-pushed
the
inappchat-sslfix
branch
from
02d164e
to
2d81f9d
Compare
please let me know your thoughts |
sidmohanty11
changed the title
Sing-Li
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useSslwas treated as a function that didn't give us a resolved valuehostas a component level parameter and removed the env variable dependency, at development, it points tohttp://localhost:3000, and in prod (as of now) it resolves into Debdut sir's RC instance (which is https://community.liaison.rocketchat.digital/)