Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] mainstage design with coutdown, local date showtime and speakers #97

Merged
merged 6 commits into from
Mar 30, 2022

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented Mar 23, 2022

  • Added a countdown similar to livestorm's
  • Added locale time for showing the date (in my case 3;30PM Asia/Calcutta) (similar to livestorm)
  • Added topic to the schema of speakers
  • On the day of the event (when the timer expires, it will change to We are now live!) and "The date of the summit will be April 6th starting at ..." will change to Event is live now!✨

MAINSTAGE

communityrcspeakers

STRAPI

strapispeakers

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2022

This pull request introduces 1 alert when merging 94293c2 into 2a31cab - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Sing-Li
Copy link
Member

Sing-Li commented Mar 25, 2022

@sidmohanty11 please add somewhere visible in BOLD letters:

Bookmark this page and come back on April 6 for the LIVE conference

@Sing-Li
Copy link
Member

Sing-Li commented Mar 26, 2022

@sidmohanty11 please update with the new format we talked about in the meeting.

@sidmohanty11
Copy link
Contributor Author

Yes will update it asap, I just need some help with typography and placement of components for which @samad-yar-khan and @demonicirfan can help. Then we require the headshots of speakers hosted on a CDN so that we can whitelist them in next.config file. Making the layout more appealing will be the goal, will keep you updated on the progress.

@Dnouv
Copy link
Member

Dnouv commented Mar 27, 2022

Hello @sidmohanty11
I would love to contribute if you require any additional help with typography and placement of components.
Please feel free to ping me. Thank you!

@sidmohanty11
Copy link
Contributor Author

@Dnouv join here https://open.rocket.chat/group/2snhdmderhjmpjbpd?msg=ho2dYd2yJzwvqPkke

@Dnouv
Copy link
Member

Dnouv commented Mar 27, 2022

I tried but it states "Room does not exist or you may not have permission".

@sidmohanty11
Copy link
Contributor Author

@Dnouv I have added you in the discussion, please feel free to add your points to the design (check the thread for figma link)

@lgtm-com
Copy link

lgtm-com bot commented Mar 27, 2022

This pull request introduces 1 alert when merging 52fe418 into 0930180 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@sidmohanty11
Copy link
Contributor Author

@Sing-Li I've added content + bookmark alert and setup the barebone for speakers here, @samad-yar-khan will be adding to the backend schema of speakers (adding timing and "live" on the specific date functionalities). @demonicirfan can check with the typography and design. Please review this PR.
Thank you.

Desktop

desktopview-speakers

Mobile

mobileview-speakers

@samad-yar-khan
Copy link
Contributor

@Sing-Li I've added content + bookmark alert and setup the barebone for speakers here, @samad-yar-khan will be adding to the backend schema of speakers (adding timing and "live" on the specific date functionalities). @demonicirfan can check with the typography and design. Please review this PR. Thank you.

Desktop

desktopview-speakers

Mobile

mobileview-speakers

@sidmohanty11 Almost through with it. Will raise a PR by night and will start with the component for the main page after that

@Sing-Li Sing-Li merged commit 8b32f11 into RocketChat:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants