Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to fix the markdown for mention user #5367

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

brf153
Copy link
Contributor

@brf153 brf153 commented Nov 27, 2023

Proposed changes

Fixed the bug in the markup so that it now works for user mentions.

Issue(s)

closes #5302
Depends on RocketChat/fuselage#1228

How to test or reproduce

Create a message using various Markdown formatting options and include mentions using '@'. For instance, *Hello @brf153, how are you?*

Screenshots

From
WhatsApp Image 2023-11-27 at 21 59 58

To
WhatsApp Image 2023-11-27 at 21 55 54

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added the necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Additional Comment

I need to add changes to the fuselage repository of Rocket Chat. After that, this pull request will work fine.

@diegolmello
Copy link
Member

Thanks for your contribution, @brf153!
We're going to evaluate this asap.
Just be aware we're in the middle of a long release, so it might take longer than expected to review it.

@brf153
Copy link
Contributor Author

brf153 commented Nov 29, 2023

@diegolmello Sure sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usernames removed from message using /me
2 participants