Show URL attributes after applying Handlebars.SafeString

* Show URL attributes after applying Handlebars.SafeString; Fix #2338 * Check if string before applying safestring.
RocketChat · Apr 4, 2016 · c1c0867 · c1c0867
1 parent 9f44a4f
commit c1c0867
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/rocketchat-oembed/client/oembedUrlWidget.coffee b/packages/rocketchat-oembed/client/oembedUrlWidget.coffee
@@ -17,10 +17,12 @@ getDescription = (self) ->
 
 Template.oembedUrlWidget.helpers
 	description: ->
-		return getDescription this
+		description = getDescription this
+		return new Handlebars.SafeString description if _.isString description
 
 	title: ->
-		return getTitle this
+		title = getTitle this
+		return new Handlebars.SafeString title if _.isString title
 
 	image: ->
 		if not this.meta?

diff --git a/packages/rocketchat-oembed/client/oembedUrlWidget.html b/packages/rocketchat-oembed/client/oembedUrlWidget.html
@@ -18,7 +18,7 @@
 				<div style="color: #AAA;">{{parsedUrl.host}}</div>
 				{{#if title}}
 					<div>
-						<a href="{{url}}" target="_blank"><strong>{{title}}</strong></a>
+						<a href="{{url}}" target="_blank"><strong>{{{title}}}</strong></a>
 					</div>
 				{{/if}}
 				{{{description}}}