Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of upload office documents in chat room #1058

Closed
steedos opened this issue Oct 10, 2015 · 6 comments
Closed

Support of upload office documents in chat room #1058

steedos opened this issue Oct 10, 2015 · 6 comments
Assignees

Comments

@steedos
Copy link

steedos commented Oct 10, 2015

Currently, only images are valid to upload. and there is a bug, if i drag a file to the window, it will ignore the file extension check.

Also, it's need the admin settings for documents size limit.

@graywolf336
Copy link
Contributor

There's already an issue for setting of max upload file size: #756.

@gmsecrieru
Copy link
Contributor

  • Create Admin setting to define if uploads are enabled, allowed media types, max file size
  • Change form validation to reflect newly-added setting
  • Inspect/fix drag-and-drop upload

@IQ2022
Copy link

IQ2022 commented Oct 15, 2015

Go for it, we have an issue with anyone dropping a file into chat, it hang chat and you might actually lose connection to room.

@gmsecrieru
Copy link
Contributor

It turns out the bypassing of files with different content types than those explicitly defined is related to an existing bug on jalik:ufs. I have created a PR to fix that (jalik/meteor-jalik-ufs#19), hopefully it gets accepted soon and we can leverage this fix.

I will put this on hold while we wait for a reply from the package maintainer. Otherwise we can add my forked version to our packages.

@jalik
Copy link

jalik commented Oct 16, 2015

@gmsecrieru, thanks for the PR, I've accepted it and published new version of UFS packages (now also include the MIT LICENSE I forgot to add). I'm glad to see my work used and fixed by others ;-)

@gmsecrieru
Copy link
Contributor

@jalik 👍 thanks for accepting it and thank you as well for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants