Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown hyperlink syntax #31766

Open
4 of 5 tasks
Zzzenk opened this issue Dec 21, 2023 · 14 comments
Open
4 of 5 tasks

Markdown hyperlink syntax #31766

Zzzenk opened this issue Dec 21, 2023 · 14 comments

Comments

@Zzzenk
Copy link

Zzzenk commented Dec 21, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Operating System

  • macOS
  • Windows
  • Linux

Operating System Version

No response

It happens on the web browser too?

Yes, it happens on the web browser too

Rocket.Chat Desktop App Version

3.9.11

Rocket.Chat Server Version

6.4.5

Describe the bug

If to type between two hyperlink any text in square brackets it's broke markdown.

Example:

## [v2023.12.21.3](https://https://github.com/)
- [BUG #11111](https://https://github.com/) - [BACK] changelog description
- [BUG #22222](https://github.com/) - changelog description
- [BUG #33333](https://https://github.com/) - [BACK] changelog description
- [BUG #44444](https://github.com/) - changelog description

image

How to Reproduce

  1. Copy and paste followng text to any chat:
## [v2023.12.21.3](https://https://github.com/)
- [BUG #11111](https://https://github.com/) - [BACK] changelog description
- [BUG #22222](https://github.com/) - changelog description
- [BUG #33333](https://https://github.com/) - [BACK] changelog description
- [BUG #44444](https://github.com/) - changelog description
  1. See broken markdown

Describe your Expected behavior

No response

Anything else

No response

Are you willing to submit a code contribution?

  • Yes, I am willing to submit a Pull Request!
@preeesha
Copy link

preeesha commented Dec 27, 2023

Hey @jeanfbrito,
I see this as a major flaw in both the user experience and system. According to me, it's an important fix to make in the upcoming releases of the platform.

I would love to be assigned to work on this issue.

Thanks for the support,
Prisha

@jeanfbrito
Copy link
Contributor

jeanfbrito commented Dec 28, 2023 via email

@preeesha
Copy link

Okay, thanks for the highlight. I am starting to working on this now.
Will shortly update you with the progress.

@preeesha
Copy link

preeesha commented Dec 30, 2023

Hi @jeanfbrito,

I've looked into the issue, and it seems like a bug in the Rocket.Chat's web view's rendering system rather than of the electron app. The problem lies in the code responsible for rendering the messaging web view.

Screenshots:

  1. Here's the code that handles the rendering of Rocket.Chat's messaging web view
    image
  2. DOM rendering webview
    image

To fix this, it needs attention in the Rocket.Chat (https://github.com/RocketChat/Rocket.Chat) repository.

Injecting temporary CSS or JavaScript here isn't a good long-term solution.

Please consider escalating this to the Rocket.Chat repository for a proper fix. Let me know if you need more info or help.

Thanks,
Prisha Gupta

@aryanpnd
Copy link

haha, nice AI response it was @preeesha , any it doesn't solve the issue
its only need a small JS fix.

@preeesha
Copy link

Ohhh I see the humour rolling @aryanpnd. It's sad to see people getting confused between human and AI responses nowadays. After all, it's the age of AI, I get you it's not your mistake.

Nonetheless, rather than commenting on stuff that doesn't solve the issue, you should just solve the issue. It's highly advisable to maintain professionalism here.

I hope you get the point. And I wish you good luck for your small JS fixes.

Thank you

@Giridharan002
Copy link

Fixed issue #31766: Resolved a problem in the Fuselage repository with this pull request: RocketChat/fuselage#1260

@Zzzenk
Copy link
Author

Zzzenk commented Feb 13, 2024

@jeanfbrito hi! I saw v3.9.13 was released yesterday, but there is no fix #31766. Will it be added in 3.9.14?

@jeanfbrito
Copy link
Contributor

I'm sorry, I closed by mistake. This is an issue with the core, so I will move it to there.
It's not the desktop app that does that.

@jeanfbrito jeanfbrito reopened this Feb 15, 2024
@jeanfbrito
Copy link
Contributor

@dougfabris can you take a look? Seems we have the fix already.

@jeanfbrito jeanfbrito transferred this issue from RocketChat/Rocket.Chat.Electron Feb 15, 2024
@Zzzenk
Copy link
Author

Zzzenk commented Feb 21, 2024

@jeanfbrito hi! Do you know when this fix will be released? I'm really waiting for it))

@Zzzenk
Copy link
Author

Zzzenk commented Feb 26, 2024

@jeanfbrito hello?

@Zzzenk
Copy link
Author

Zzzenk commented Mar 13, 2024

Anybody?

@Zzzenk
Copy link
Author

Zzzenk commented Apr 3, 2024

"Awesome" support... Total ignore...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants