Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named parameters in translations #89

Closed
ujuc opened this issue Jun 1, 2015 · 6 comments
Closed

Use named parameters in translations #89

ujuc opened this issue Jun 1, 2015 · 6 comments
Assignees
Milestone

Comments

@ujuc
Copy link
Contributor

ujuc commented Jun 1, 2015

hi

I translate i18n/en.i18n.json > i18n/ko.i18n.json.

1 problem..

this line Room name changed to: <em>%s</em> by <em>%s</em>
Korean translate is 방이름 변경 : <em>%s</em> 에서 <em>>%s</em>

edit <em>%s1</em> by <em>%s2</em>.
Korean translate is <em>%s2</em> 에서 <em>%s1</em>

Thanks.

@engelgabriel
Copy link
Member

Can you do a Pull Request?

@engelgabriel
Copy link
Member

@marceloschmidt I think we have to use name parameters.

@ujuc Can you submit your file in a Pull Request so we can test it?

@engelgabriel engelgabriel modified the milestones: v0.1, v0.2 Jun 1, 2015
@engelgabriel engelgabriel changed the title Translation Word. Use named parameters in translations Jun 1, 2015
@ujuc
Copy link
Contributor Author

ujuc commented Jun 1, 2015

@engelgabriel yes 😄

engelgabriel added a commit that referenced this issue Jun 1, 2015
Add korean translation (#89)

Thanks to @ujuc
@marceloschmidt
Copy link
Member

I've started using named parameters for phrases that include more than one %s. I have already inserted the correct named parameters where you had put %s1 and %s2. Please update accordingly if needed. Thanks for your help!

@marceloschmidt
Copy link
Member

PR ready to merge: #98

@ujuc
Copy link
Contributor Author

ujuc commented Jun 2, 2015

👍

mrsimpson referenced this issue in assistify/Rocket.Chat Sep 4, 2017
…nels

Allow user management in expert channels
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
- Added a force quit option to the app, if this is set, the application
will quit. Otherwise it'll just hide.
- Fixed bug in windows, where you had to triple-click the tray icon show
the app
bhardwajaditya pushed a commit to bhardwajaditya/Rocket.Chat that referenced this issue Nov 21, 2019
add viasat system user to replace rocket.cat for messaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants