Fixes #1194: OEmbed http requests use "request" npm package

[ghost]

Closes #1194

OEmbed http requests use "request" npm package instead of official node modules.

[engelgabriel]

Thanks @nishimaki10
@rodrigok can you review this?

[rodrigok]

@nishimaki10 awesome, but I have some questions.

Why not use the Meteor's HTTP module http://docs.meteor.com/#/full/http_call ?

Is there some way to limit the request size? Users can past URL of big files and we don't wan't to download the entire file to get only the headers.

[ghost]

@rodrigok Thanks for review!

I have used for the Meteor first time. I did not know that exists Meteor's HTTP module. Thank you for the valuable information.

But, may not be able to implement limit the request size. We have to control the request stream. It's probably like this. I looking at this, it is impossible to touch the stream.

What should I do?

[rodrigok]

@nishimaki10 If you can limit the request using the lib request go ahead and use it, but use the internal one HTTPInternals.NpmModules.request.module. What do you think?

[ghost]

@rodrigok I see. I will try to implement using the HTTPInternals.NpmModules.request.module. Thanks!

[rodrigok]

What about the gunzip? The library do the unzip for each chunk? I don't think so, can you test?

[ghost]

Yes. The request module pipe gunzip for each chunk. see also. I think that this library is made well.
My Test:
gziped site
Screenshot:

[ghost]

Twitter, GitHub, etc, etc... I tested many sites. All OK.
The content-encoding: gzip header exists properly in response if site enabled gzip. e.g. Twitter, GitHub.
Thanks.

[rodrigok]

LGTM

[rodrigok]

@nishimaki10 sorry about that, but, can you fix the conflicts?

[ghost]

@rodrigok OK, solved.