Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of oauth2 client support for gitlab server flow #512 #556

Merged
merged 2 commits into from
Aug 23, 2015
Merged

Conversation

Sing-Li
Copy link
Member

@Sing-Li Sing-Li commented Aug 23, 2015

Tested.

NOTE:
See packages/gitlab/gitlab_common.js -- A new setting needs to be created to configure the gitlab server location.

See client/views/login/services.coffee -- Need a GitLab icon or SVG glyph

@Sing-Li
Copy link
Member Author

Sing-Li commented Aug 23, 2015

Please merge down so we (including GitLab) can party asap.

I'll open another issue for settings configuring the currently hard-coded GitLab server URL.

engelgabriel added a commit that referenced this pull request Aug 23, 2015
initial implementation of oauth2 client support for gitlab server flow  #512
@engelgabriel engelgabriel merged commit 945e2fe into RocketChat:master Aug 23, 2015
@Sing-Li Sing-Li deleted the gitlab-oauth branch August 23, 2015 18:25
@engelgabriel engelgabriel modified the milestone: GitLab 0.8 Aug 23, 2015
@engelgabriel engelgabriel modified the milestones: 0.40.0, GitLab Jan 24, 2017
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this pull request Jul 10, 2018
* New sidebar style and hiding quick access

* Adds changeable sidebar color

* Get window background style for dynamic sidebar

* Resizing icons

* Uses sidebar-item color

* Update start-page.less
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this pull request Jul 10, 2018
* New sidebar style and hiding quick access

* Adds changeable sidebar color

* Get window background style for dynamic sidebar

* Resizing icons

* Uses sidebar-item color

* Update start-page.less
Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this pull request Apr 4, 2019
…analysis

[FIX] Smarti performance by on-demand-analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants