Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Update katex to v0.9.0 #8402

Merged
merged 1 commit into from
Jun 12, 2018
Merged

[NEW] Update katex to v0.9.0 #8402

merged 1 commit into from
Jun 12, 2018

Conversation

pitamar
Copy link
Contributor

@pitamar pitamar commented Oct 5, 2017

@RocketChat/core

@pitamar
Copy link
Contributor Author

pitamar commented Nov 9, 2017

@rodrigok
Hi, it's been a while since I opened the PR. Is there something missing?
Thanks

@geekgonecrazy
Copy link
Contributor

@pitamar Thanks for the PR. Can you summarize a bit more whats in the update?

Katex is one of those things most of us aren't super familiar with making use of. I think in the past we've actually had to downgrade a few packages of this nature because of performance issues.

@pitamar
Copy link
Contributor Author

pitamar commented Nov 14, 2017

Hi @geekgonecrazy

The currently used version of Katex in RocketChat is 0.7.1.
There has been many updates to the library since though.
I concentrated them here:

v0.8.3 (2017-08-27)

New features:

Bug fixes:

Other changes:

v0.8.2 (2017-08-17)

New features:

Bug fixes:

Other changes:

v0.8.1 (2017-08-11)

The v0.8.0 release did not include the SVG images which are necessary for rendering wide and stretchy accents as well as \overbrace and \underbrace. This release corrects that.

Note that if you're including copies of KaTeX in your web application, you should now include the dist/images directory in addition to the usual the dist/fonts directory.

Many thanks to @spicyj for fixing the issue so quickly.

v0.8.0 (2017-08-11)

Breaking changes:

New features:

Other changes:

Infra changes:

Misc:

As you can can see most of the changes are bug fixes or addition of new features (like new symbols).
All in all, besides many improvements, it doesn't seem to be a dramatic change.
I didn't feel any slowdown using the new version of Katex. Are there any specific tests you'd like me to perform?

Thanks =)
Itamar

@pitamar
Copy link
Contributor Author

pitamar commented Nov 25, 2017

Is there anything I can do to help?
Do you prefer not to upgrade the katex version? is there a reason to it?

@RocketChat/core

@engelgabriel engelgabriel added this to the 0.66.0 milestone May 22, 2018
@engelgabriel
Copy link
Member

Maybe we should use the version v0.9.0

https://github.com/Khan/KaTeX/releases

@pitamar
Copy link
Contributor Author

pitamar commented May 22, 2018

ye, that version was the most recent at the time. if you want i update the pull request for 0.9.0

@engelgabriel
Copy link
Member

@pitamar Please do so we can merge it.

@pitamar
Copy link
Contributor Author

pitamar commented May 24, 2018

@engelgabriel Ok, I pushed a new commit for version 0.9.0. seems to work fine to me

@ggazzo ggazzo changed the title update katex to version 0.8.3 [NEW] Update katex to v0.9.0 Jun 12, 2018
@ggazzo ggazzo merged commit 9b1322e into RocketChat:develop Jun 12, 2018
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants