joinRoom returns if room is already added #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if room doesn't exist.
|
@rodrigok if you get a chance could you take a look at this. Using some of your model stuff want to make sure all looks good before merging this. |
geekgonecrazy
added a commit
that referenced
this pull request
Sep 23, 2015
joinRoom returns if room is already added
|
@geekgonecrazy looks good 😄 |
|
@rodrigok haha had marcelo take a peak. Had hubot-rocketchat changes that depended on it. So was trying to get it in asap :) |
This was referenced Nov 30, 2023
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also returns useful error if room doesn't exist.
Added this mainly to make interacting with the bot better.