Fix #857 Cannot add user to room. #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds arugment validation.
This was referenced Sep 23, 2015
|
@marceloschmidt - insomnia? |
|
@Sing-Li the label is added by waffle.io 😛 |
|
I'm looking into this.. I found some other bugs, trying to fix them too |
|
btw, thanks @rwakida for the quick fix 😄 |
| @@ -13,7 +19,7 @@ Meteor.methods | |||
| if room.usernames.indexOf(data.username) isnt -1 | |||
| return | |||
|
|
|||
| newUser = RocketChat.models.Users.findOneByUsername username: data.username | |||
There was a problem hiding this comment.
You made a lot of changes. It's hard to catch everything. 😄
I like how you consolidated the logic into the models. It should be a lot easier to maintain.
|
N/P @sampaiodiego . I'll be the late night Hawaii tech support. 😀 |
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where username incorrectly passed to findOneByUsername. Also adds argument validation.