Fix #911. Set MAIL_URL variable after Meteor.startup #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RocketChat.settings have been initialized. RocketChat settings are loaded ASAP as of 39fe136 RocketChat.settings depends on Meteor.settings under the covers, but Meteor.settings doesn't seem to return values until Meteor is fully started. Thus, we can only call RocketChat.settings.get after Meteor.startup
|
The MAIL_URL is only set at startup. Changing the SMTP settings via the UI has no effect on the MAIL_URL environment variable. Thus, this fix only works when:
|
|
This looks good! So if they change SMTP settings in DB is a restart required pretty much regardless? |
|
@geekgonecrazy yup, from what I can tell the MAIL_URL is only set at startup (rocketchat-lib/settings/server/startup.coffee file). UI and direct DB changes have no effect on MAIL_URL and therefore email verification. |
rodrigok
added a commit
that referenced
this pull request
Sep 28, 2015
Fix #911. Set MAIL_URL variable after Meteor.startup
|
SMTP for account registration now works but it is still broken for password resetting and re-sending email confirmation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set environment value after RocketChat.settings have been initialized.
RocketChat settings are loaded ASAP as of 39fe136
RocketChat.settings depends on Meteor.settings under the covers, but Meteor.settings
doesn't seem to return values until Meteor is fully started. Thus, we
can only call RocketChat.settings.get after Meteor.startup