Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support ZWJ emoji sequences in MessageEmoji components #1432

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Vansh5632
Copy link

Summary

This PR adds support for ZWJ (Zero Width Joiner) emoji sequences in the MessageEmoji and MessageEmojiBase components. These changes ensure that complex emojis, such as family emojis, are correctly rendered.

Changes

  • Updated MessageEmojiBase to detect and handle ZWJ sequences.
  • Ensured that the MessageEmoji component correctly passes props and classNames for these sequences.

Testing

  • Manually tested ZWJ emojis in messages to ensure correct rendering.
  • Ran existing test suites to confirm no regressions.

Related Issues

Closes #<issue_number> (if applicable)

Copy link

changeset-bot bot commented Aug 27, 2024

⚠️ No Changeset found

Latest commit: 2404349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vansh5632 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Vansh5632 Vansh5632 changed the title Fix/emoji zwj sequence support(closed #1020) Fix:emoji zwj sequence support(closes #1020) Aug 27, 2024
@Vansh5632 Vansh5632 changed the title Fix:emoji zwj sequence support(closes #1020) fix: support ZWJ emoji sequences in MessageEmoji components Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants