Fix method comment, make a method const that can be

Rosefield · Jul 17, 2021 · 1619d9d · 1619d9d
1 parent e04082f
commit 1619d9d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/cascadia/TerminalApp/Pane.cpp b/src/cascadia/TerminalApp/Pane.cpp
@@ -461,7 +461,7 @@ bool Pane::_IsAdjacent(const std::shared_ptr<Pane> first,
                        const Pane::PanePoint firstOffset,
                        const std::shared_ptr<Pane> second,
                        const Pane::PanePoint secondOffset,
-                       const FocusDirection& direction)
+                       const FocusDirection& direction) const
 {
     // Since float equality is tricky (arithmetic is non-associative, commutative),
     // test if the two numbers are within an epsilon distance of each other.

diff --git a/src/cascadia/TerminalApp/Pane.h b/src/cascadia/TerminalApp/Pane.h
@@ -150,13 +150,13 @@ class Pane : public std::enable_shared_from_this<Pane>
     bool _Resize(const winrt::Microsoft::Terminal::Settings::Model::ResizeDirection& direction);
     bool _NavigateFocus(const winrt::Microsoft::Terminal::Settings::Model::FocusDirection& direction);
 
-    bool _IsAdjacent(const std::shared_ptr<Pane> first, const PanePoint firstOffset, const std::shared_ptr<Pane> second, const PanePoint secondOffset, const winrt::Microsoft::Terminal::Settings::Model::FocusDirection& direction);
+    bool _IsAdjacent(const std::shared_ptr<Pane> first, const PanePoint firstOffset, const std::shared_ptr<Pane> second, const PanePoint secondOffset, const winrt::Microsoft::Terminal::Settings::Model::FocusDirection& direction) const;
     FocusNeighborSearch _FindNeighborFromFocus(const winrt::Microsoft::Terminal::Settings::Model::FocusDirection& direction,
                                                FocusNeighborSearch focus,
                                                const bool focusIsSecondSide,
                                                const PanePoint offset);
     FocusNeighborSearch _FindFocusAndNeighbor(const winrt::Microsoft::Terminal::Settings::Model::FocusDirection& direction,
-                                              const Pane::PanePoint offset);
+                                              const PanePoint offset);
 
     void _CloseChild(const bool closeFirst);
     winrt::fire_and_forget _CloseChildRoutine(const bool closeFirst);

diff --git a/src/cascadia/TerminalApp/TerminalTab.cpp b/src/cascadia/TerminalApp/TerminalTab.cpp
@@ -498,10 +498,11 @@ namespace winrt::TerminalApp::implementation
     }
 
     // Method Description:
-    // - Attempt to move a separator between panes, as to resize each child on
-    //   either size of the separator. See Pane::ResizePane for details.
+    // - Attempts to swap the location of the focused pane with another pane
+    //   according to direction. When there are multiple adjacent panes it will
+    //   select the first one (top-left-most).
     // Arguments:
-    // - direction: The direction to move the separator in.
+    // - direction: The direction to move the pane in.
     // Return Value:
     // - <none>
     void TerminalTab::MovePane(const FocusDirection& direction)