Issue #1320: tidying

RotherOSS · Nov 15, 2021 · 380f236 · 380f236
1 parent 9595b26
commit 380f236
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/Kernel/Config/Defaults.pm b/Kernel/Config/Defaults.pm
@@ -2117,10 +2117,9 @@ sub Get {
 sub Set {
     my ( $Self, %Param ) = @_;
 
-    for (qw(Key)) {
-        if ( !defined $Param{$_} ) {
-            $Param{$_} = '';
-        }
+    # assign default values
+    for my $Key (qw(Key)) {
+        $Param{$Key} //= '';
     }
 
     # debug

diff --git a/Kernel/System/SysConfig.pm b/Kernel/System/SysConfig.pm
@@ -3361,11 +3361,11 @@ sub ConfigurationDeploy {
 
     $Param{NoValidation} //= 0;
 
-    # TODO: use the absolute path
     my $BasePath = 'Kernel/Config/Files/';
 
     # Parameter 'FileName' is intentionally not documented in the API as it is only used for testing.
-    my $TargetPath = $BasePath . ( $Param{FileName} || 'ZZZAAuto.pm' );
+    my $FileName   = $Param{FileName} || 'ZZZAAuto.pm';
+    my $TargetPath = $BasePath . $FileName;
 
     my $SysConfigDBObject = $Kernel::OM->Get('Kernel::System::SysConfig::DB');
 

diff --git a/scripts/test/SysConfig/ConfigurationDeploy.t b/scripts/test/SysConfig/ConfigurationDeploy.t
@@ -457,6 +457,7 @@ for my $Test (@Tests1) {
             next TEST;
         }
 
+        # The param FileName overrides the default file name ZZZAAuto.pm
         $SysConfigObject->ConfigurationDeploy(
             %{ $Test->{Config} },
             Force    => 1,