Issue #480: check whether option parsing worked

RotherOSS · Sep 28, 2020 · 793f88e · 793f88e
1 parent cf67ff4
commit 793f88e
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/bin/otobo.SetPermissions.pl b/bin/otobo.SetPermissions.pl
@@ -67,8 +67,8 @@
 
 my $ExitStatus = 0;
 
-sub PrintUsage {
-    my ($DefaultGroupNames) = @_;
+sub PrintUsageAndExit {
+    my ($DefaultGroupNames, $ExitCode) = @_;
 
     print <<"END_USAGE";
 
@@ -94,7 +94,7 @@ sub PrintUsage {
 
 END_USAGE
 
-    return;
+    exit $ExitCode;
 }
 
 sub Run {
@@ -139,12 +139,10 @@ sub Run {
         'dry-run'                 => \$DryRun,
         'skip-article-dir'        => \$SkipArticleDir,
         'skip-regex=s'            => \@SkipRegex,
-    );
+    ) or PrintUsageAndExit(\%DefaultGroupNames, 1);
 
     if ( $Help ) {
-        PrintUsage(\%DefaultGroupNames);
-
-        exit 0;
+        PrintUsageAndExit(\%DefaultGroupNames, 0);
     }
 
     if ( $> != 0 ) {    # $EFFECTIVE_USER_ID