Issue #639: added a code comment, tidying

RotherOSS · Nov 16, 2020 · 98c9f41 · 98c9f41
1 parent 8ba7652
commit 98c9f41
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/Kernel/System/DB/mysql.pm b/Kernel/System/DB/mysql.pm
@@ -793,9 +793,8 @@ sub Insert {
     my $ConfigObject   = $Kernel::OM->Get('Kernel::Config');
     my $DateTimeObject = $Kernel::OM->Create('Kernel::System::DateTime');
 
-    my $SQL    = '';
-    my @Keys   = ();
-    my @Values = ();
+    my $SQL = '';
+    my ( @Keys, @Values );
     for my $Tag (@Param) {
         if ( $Tag->{Tag} eq 'Insert' && $Tag->{TagType} eq 'Start' ) {
             if ( $ConfigObject->Get('Database::ShellOutput') ) {
@@ -805,6 +804,8 @@ sub Insert {
                 $SQL .= $Self->{'DB::Comment'}
                     . "----------------------------------------------------------\n";
             }
+            # TODO: might be safer to call $Self->QuoteIndetifier() for quoting the table.
+            #       but beware that $Tag->{Table} might already be quoted. 
             $SQL .= "INSERT INTO $Tag->{Table} ";
         }
         if ( $Tag->{Tag} eq 'Data' && $Tag->{TagType} eq 'Start' ) {