Issue #760: accept some of the reformatting done by Perl::Tidy

CHANGES.md

@@ -612,5 +612,3 @@
 
 # OTOBO 10.0.0 beta1 2020-01-30
  - First official OTOBO release, yippie!
-
-

Kernel/Autoload/Test.pm

@@ -14,9 +14,9 @@
 # along with this program. If not, see <https://www.gnu.org/licenses/>.
 # --
 
-use Kernel::System::Valid; ## no critic (Modules::RequireExplicitPackage)
+use Kernel::System::Valid;    ## no critic (Modules::RequireExplicitPackage)
 
-package Kernel::System::Valid; ## no critic (Modules::RequireFilenameMatchesPackage)
+package Kernel::System::Valid;    ## no critic (Modules::RequireFilenameMatchesPackage)
 
 use strict;
 use warnings;

Kernel/Autoload/Znuny4OTOBOPasswordPolicy.pm

@@ -15,9 +15,9 @@
 # along with this program. If not, see <https://www.gnu.org/licenses/>.
 # --
 
-use Kernel::Output::HTML::Layout; ## no critic (Modules::RequireExplicitPackage)
+use Kernel::Output::HTML::Layout;    ## no critic (Modules::RequireExplicitPackage)
 
-package Kernel::Output::HTML::Layout; ## no critic (Modules::RequireFilenameMatchesPackage)
+package Kernel::Output::HTML::Layout;    ## no critic (Modules::RequireFilenameMatchesPackage)
 
 use strict;
 use warnings;
@@ -29,7 +29,7 @@ our @ObjectDependencies = (
 
 # disable redefine warnings in this scope
 {
-    no warnings 'redefine'; ## no critic qw(TestingAndDebugging::ProhibitNoWarnings)
+    no warnings 'redefine';              ## no critic qw(TestingAndDebugging::ProhibitNoWarnings)
 
     # backup original Redirect()
     my $Redirect = \&Kernel::Output::HTML::Layout::Redirect;

Kernel/GenericInterface/ErrorHandling/RequestRetry.pm

@@ -167,8 +167,7 @@ sub Run {
     # Calculate interval for next execution.
     my $RetryInterval;
     if ( IsStringWithData( $Param{PastExecutionData}->{RetryInterval} ) ) {
-        $RetryInterval
-            = int( $Param{PastExecutionData}->{RetryInterval} * $Param{ModuleConfig}->{RetryIntervalFactor} );
+        $RetryInterval = int( $Param{PastExecutionData}->{RetryInterval} * $Param{ModuleConfig}->{RetryIntervalFactor} );
         if (
             IsStringWithData( $Param{ModuleConfig}->{RetryIntervalMax} )
             && $RetryInterval > $Param{ModuleConfig}->{RetryIntervalMax}

Kernel/Language.pm

@@ -274,7 +274,7 @@ sub Translate {
 
     # Expecting that the replacements do not contain a '%'.
     # That the substitutions stop at the first undefined replacement can be considered a bug.
-    for my $Replacement ( @Replacements ) {
+    for my $Replacement (@Replacements) {
         return $Text unless defined $Replacement;
 
         $Text =~ s/\%(?:s|d)/$Replacement/;

Kernel/Modules/AgentTicketActionCommon.pm

@@ -842,7 +842,7 @@ sub Run {
             # Do not validate only if object type is Article and CreateArticle value is not defined, or Field is invisible.
             if (
                 !( $DynamicFieldConfig->{ObjectType} eq 'Article' && !$GetParam{CreateArticle} )
-                && $Visibility{ 'DynamicField_'.$DynamicFieldConfig->{Name} }
+                && $Visibility{ 'DynamicField_' . $DynamicFieldConfig->{Name} }
                 )
             {
 

Kernel/Modules/AgentTicketEmail.pm

@@ -1423,7 +1423,7 @@ sub Run {
             my $ValidationResult;
 
             # do not validate on invisible fields
-            if ( !$ExpandCustomerName && $Visibility{ 'DynamicField_'.$DynamicFieldConfig->{Name} } ) {
+            if ( !$ExpandCustomerName && $Visibility{ 'DynamicField_' . $DynamicFieldConfig->{Name} } ) {
 
                 $ValidationResult = $DynamicFieldBackendObject->EditFieldValueValidate(
                     DynamicFieldConfig   => $DynamicFieldConfig,

Kernel/Modules/AgentTicketPhone.pm

@@ -1237,7 +1237,7 @@ sub Run {
             my $ValidationResult;
 
             # do not validate on invisible fields
-            if ( !$ExpandCustomerName && $Visibility{ 'DynamicField_'.$DynamicFieldConfig->{Name} } ) {
+            if ( !$ExpandCustomerName && $Visibility{ 'DynamicField_' . $DynamicFieldConfig->{Name} } ) {
 
                 $ValidationResult = $DynamicFieldBackendObject->EditFieldValueValidate(
                     DynamicFieldConfig   => $DynamicFieldConfig,

Kernel/Modules/CustomerTicketMessage.pm

@@ -628,7 +628,7 @@ sub Run {
             my $ValidationResult;
 
             # do not validate on insisible fields
-            if ( $Visibility{ 'DynamicField_'.$DynamicFieldConfig->{Name} } ) {
+            if ( $Visibility{ 'DynamicField_' . $DynamicFieldConfig->{Name} } ) {
 
                 $ValidationResult = $BackendObject->EditFieldValueValidate(
                     DynamicFieldConfig   => $DynamicFieldConfig,

Kernel/Modules/CustomerTicketZoom.pm

@@ -747,7 +747,7 @@ sub Run {
             my $ValidationResult;
 
             # do not validate invisible fields
-            if ( $Visibility{ 'DynamicField_'.$DynamicFieldConfig->{Name} } ) {
+            if ( $Visibility{ 'DynamicField_' . $DynamicFieldConfig->{Name} } ) {
                 $ValidationResult = $BackendObject->EditFieldValueValidate(
                     DynamicFieldConfig   => $DynamicFieldConfig,
                     PossibleValuesFilter => $PossibleValuesFilter,

Kernel/Modules/Installer.pm

@@ -1229,7 +1229,7 @@ sub Run {
 
         # Only if we have mod_perl we have to restart.
         if ( exists $ENV{MOD_PERL} ) {
-            eval 'require mod_perl';               ## no critic qw(BuiltinFunctions::ProhibitStringyEval)
+            eval 'require mod_perl';    ## no critic qw(BuiltinFunctions::ProhibitStringyEval)
             if ( defined $mod_perl::VERSION ) {
                 $Webserver = 'Apache2 + mod_perl';
                 if ( -f '/etc/SuSE-release' ) {

Kernel/Modules/MigrateFromOTRS.pm

@@ -588,7 +588,7 @@ sub _Finish {
 
     # Only if we have mod_perl we have to restart.
     if ( exists $ENV{MOD_PERL} ) {
-        eval 'require mod_perl';               ## no critic qw(BuiltinFunctions::ProhibitStringyEval)
+        eval 'require mod_perl';    ## no critic qw(BuiltinFunctions::ProhibitStringyEval)
         if ( defined $mod_perl::VERSION ) {
             $Webserver = 'systemctl restart apache2';
             if ( -f '/etc/SuSE-release' ) {

Kernel/Output/HTML/Layout.pm

@@ -80,7 +80,7 @@ sub new {
     my ( $Type, %Param ) = @_;
 
     # allocate new hash for object
-    my $Self = bless { %Param }, $Type;
+    my $Self = bless {%Param}, $Type;
 
     # set debug
     $Self->{Debug} = 0;
@@ -146,7 +146,7 @@ sub new {
 
     # set charset if there is no charset given
     $Self->{UserCharset} = 'utf-8';
-    $Self->{Charset}     = $Self->{UserCharset};                            # just for compat.
+    $Self->{Charset}     = $Self->{UserCharset};                                                                         # just for compat.
     $Self->{SessionID}   = $Param{SessionID} || '';
     $Self->{SessionName} = $Param{SessionName} || 'SessionID';
     $Self->{CGIHandle}   = $Kernel::OM->Get('Kernel::System::Web::Request')->ScriptName() || 'No-$ENV{"SCRIPT_NAME"}';
@@ -377,7 +377,7 @@ EOF
 
     # force a theme based on host name
     my $DefaultThemeHostBased = $ConfigObject->Get('DefaultTheme::HostBased');
-    my $Host = $ENV{HTTP_HOST};
+    my $Host                  = $ENV{HTTP_HOST};
     if ( $DefaultThemeHostBased && $Host ) {
 
         THEME:
@@ -658,7 +658,7 @@ sub Redirect {
 }
 
 sub Login {
-    my ($Self, %Param) = @_;
+    my ( $Self, %Param ) = @_;
 
     # set Action parameter for the loader
     $Self->{Action} = 'Login';
@@ -1221,8 +1221,7 @@ sub NotifyNonUpdatedTickets {
     );
 
     return $Self->Notify(
-        Info => $Self->{LanguageObject}
-            ->Translate( "The following tickets are not updated: %s.", $NonUpdatedTicketsString ),
+        Info => $Self->{LanguageObject}->Translate( "The following tickets are not updated: %s.", $NonUpdatedTicketsString ),
     );
 
 }
@@ -1243,7 +1242,7 @@ generates the HTML for the page begin in the Agent interface.
 =cut
 
 sub Header {
-    my ($Self, %Param) = @_;
+    my ( $Self, %Param ) = @_;
 
     # extract params
     my $Type = $Param{Type} || '';
@@ -1521,8 +1520,7 @@ sub Header {
                 # See bug#13790 (https://bugs.otrs.org/show_bug.cgi?id=13790).
                 if ( $ConfigObject->Get('Ticket::ArchiveSystem') && $Modules{$Key}->{Block} eq 'ToolBarSearchFulltext' )
                 {
-                    $Modules{$Key}->{SearchInArchive}
-                        = $ConfigObject->Get('Ticket::Frontend::AgentTicketSearch')->{Defaults}->{SearchInArchive};
+                    $Modules{$Key}->{SearchInArchive} = $ConfigObject->Get('Ticket::Frontend::AgentTicketSearch')->{Defaults}->{SearchInArchive};
                 }
 
                 $Self->Block(
@@ -1559,8 +1557,7 @@ sub Header {
         if ( $ConfigObject->Get('Frontend::AvatarEngine') eq 'Gravatar' && $Self->{UserEmail} ) {
             my $DefaultIcon = $ConfigObject->Get('Frontend::Gravatar::DefaultImage') || 'mp';
             $Kernel::OM->Get('Kernel::System::Encode')->EncodeOutput( \$Self->{UserEmail} );
-            $Param{Avatar}
-                = '//www.gravatar.com/avatar/' . md5_hex( lc $Self->{UserEmail} ) . '?s=100&d=' . $DefaultIcon;
+            $Param{Avatar} = '//www.gravatar.com/avatar/' . md5_hex( lc $Self->{UserEmail} ) . '?s=100&d=' . $DefaultIcon;
         }
         else {
             my %User = $Kernel::OM->Get('Kernel::System::User')->GetUserData(
@@ -1801,7 +1798,7 @@ sub Print {
     my ( $Self, %Param ) = @_;
 
     # the string referenced by $Param{Content} might be modified here
-    $Self->ApplyOutputFilters( %Param );
+    $Self->ApplyOutputFilters(%Param);
 
     # There seems to be a bug in FastCGI that it cannot handle unicode output properly.
     #   Work around this by converting to an utf8 byte stream instead.
@@ -1814,7 +1811,7 @@ sub Print {
 
     # Disable perl warnings in case of printing unicode private chars,
     #   see https://rt.perl.org/Public/Bug/Display.html?id=121226.
-    no warnings 'nonchar'; ## no critic qw(TestingAndDebugging::ProhibitNoWarnings)
+    no warnings 'nonchar';    ## no critic qw(TestingAndDebugging::ProhibitNoWarnings)
 
     print ${ $Param{Output} };
 
@@ -5109,7 +5106,7 @@ sub RichTextDocumentServe {
 
             $Param{Data}->{Content} = $SafetyCheckResult{String};
 
-           # Show confirmation button to load external content explicitly only if BlockLoadingRemoteContent is disabled.
+            # Show confirmation button to load external content explicitly only if BlockLoadingRemoteContent is disabled.
             if (
                 $SafetyCheckResult{Replace}
                 && !$Kernel::OM->Get('Kernel::Config')->Get('Ticket::Frontend::BlockLoadingRemoteContent')

Kernel/Output/PDF/Ticket.pm

@@ -415,7 +415,7 @@ sub _PDFOutputTicketInfos {
             $Responsible = $Ticket{Responsible} || '-';
         }
 
-        if ( $Responsible ) {
+        if ($Responsible) {
             my $Row = {
                 Key   => $LayoutObject->{LanguageObject}->Translate('Responsible'),
                 Value => $Responsible,

Kernel/System/Calendar/Export/ICal.pm

@@ -430,7 +430,7 @@ sub Export {
 }
 
 {
-    no warnings 'redefine'; ## no critic qw(TestingAndDebugging::ProhibitNoWarnings)
+    no warnings 'redefine';    ## no critic qw(TestingAndDebugging::ProhibitNoWarnings)
 
     # Include product name and version in product ID property for debugging purposes, by redefining
     #   external library method.

Kernel/System/Calendar/Import/ICal.pm

@@ -760,7 +760,7 @@ sub _FormatTime {
 }
 
 {
-    no warnings 'redefine'; ## no critic qw(TestingAndDebugging::ProhibitNoWarnings)
+    no warnings 'redefine';    ## no critic qw(TestingAndDebugging::ProhibitNoWarnings)
 
     # Include additional optional repeatable properties used by some iCalendar implementations, in
     #   order to prevent Perl warnings.

Kernel/System/Console/Command/Dev/Tools/ImportFakeEmails.pm

@@ -36,7 +36,7 @@ package MyIMAP {    ## no critic qw(Modules::ProhibitMultiplePackages)
     our $AUTOLOAD;
 
     sub new {
-        my ($Class, %Param) = @_;
+        my ( $Class, %Param ) = @_;
 
         $Param{TotalProcessed} = 0;
         $Param{Processed}      = {};
@@ -110,7 +110,7 @@ test %s';
         return wantarray ? @Lines : \@Lines;
     }
 
-    sub select {  ## no critic qw(Subroutines::ProhibitBuiltinHomonyms)
+    sub select {    ## no critic qw(Subroutines::ProhibitBuiltinHomonyms)
         my $Self = shift;
 
         return $Self->{Total} - $Self->{TotalProcessed};
@@ -249,7 +249,7 @@ sub _ImportEmails {
 
     # Redefine PostMaster::Run so we can fail some messages
     #   and keep this change local to the current scope
-    no strict 'refs'; ## no critic (TestingAndDebugging::ProhibitNoStrict)
+    no strict 'refs';    ## no critic (TestingAndDebugging::ProhibitNoStrict)
 
     local *{'Kernel::System::MailAccount::IMAP::Connect'} = sub {
         my ( $Self, %Param ) = @_;

Kernel/System/DB/mysql.pm

@@ -33,7 +33,7 @@ sub new {
     my ( $Class, %Param ) = @_;
 
     # allocate new hash for object
-    return bless { %Param }, $Class;
+    return bless {%Param}, $Class;
 }
 
 sub LoadPreferences {

Kernel/System/Email/Sendmail.pm

@@ -131,7 +131,7 @@ sub Send {
     my $FH;
     my $GenErrorMessage = sub { return sprintf( q{Can't send message: %s!}, shift, ); };
 
-    if ( !open( $FH, '|-', "$Sendmail $Arg " ) ) { ## no critic qw(InputOutput::RequireBriefOpen)
+    if ( !open( $FH, '|-', "$Sendmail $Arg " ) ) {    ## no critic qw(InputOutput::RequireBriefOpen)
         my $ErrorMessage = $GenErrorMessage->($!);
 
         $Param{CommunicationLogObject}->ObjectLog(

Kernel/System/Main.pm

@@ -132,11 +132,10 @@ sub RequireBaseClass {
     # Load the module, if not already loaded.
     return if !$Self->Require($Module);
 
-
     my $CallingClass = caller(0);
 
     {
-        no strict 'refs'; ## no critic (TestingAndDebugging::ProhibitNoStrict)
+        no strict 'refs';    ## no critic (TestingAndDebugging::ProhibitNoStrict)
 
         # Check if the base class was already loaded.
         # This can happen in persistent environments as mod_perl (see bug#9686).