Skip to content

Commit

Permalink
Issue #1320: explicitly requires Mojolicious for S3 support
Browse files Browse the repository at this point in the history
Before it only was implicitly.
  • Loading branch information
bschmalhofer committed Oct 21, 2021
1 parent 3754e52 commit f61ef5e
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 3 deletions.
14 changes: 13 additions & 1 deletion bin/otobo.CheckModules.pl
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ =head1 DESCRIPTION
'gazelle' => 'Required packages if you want to use Gazelle webserver',
'mail' => 'Features enabling communication with a mail-server',
'performance' => 'Optional features which can increase performance',
'storage:s3' => 'Amazon Web Services, currently only S3',
'storage:s3' => 'AWS S3 compatible storage',
'zzznone' => 'Uncategorized',
);

Expand Down Expand Up @@ -578,6 +578,18 @@ =head1 DESCRIPTION
},

# Feature storage:s3
{
Module => 'Mojolicious',
Features => ['storage:s3'],
Comment => 'support for the REST requests to the S3 storage',
InstTypes => {
aptget => undef,
emerge => undef,
yum => undef,
zypper => undef,
ports => undef,
},
},
{
Module => 'Mojolicious::Plugin::AWS',
Features => ['storage:s3'],
Expand Down
8 changes: 7 additions & 1 deletion cpanfile
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,9 @@ feature 'mail:ssl', 'Suppport for mail:ssl' => sub {
};

feature 'optional', 'Suppport for optional' => sub {
# support for the REST requests to the S3 storage
requires 'Mojolicious';

# support for S3 using Mojo::UserAgent
requires 'Mojolicious::Plugin::AWS';

Expand Down Expand Up @@ -352,7 +355,10 @@ feature 'performance:redis', 'Suppport for performance:redis' => sub {

};

feature 'storage:s3', 'Amazon Web Services, currently only S3' => sub {
feature 'storage:s3', 'AWS S3 compatible storage' => sub {
# support for the REST requests to the S3 storage
requires 'Mojolicious';

# support for S3 using Mojo::UserAgent
requires 'Mojolicious::Plugin::AWS';

Expand Down
5 changes: 4 additions & 1 deletion cpanfile.docker
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,10 @@ requires 'Const::Fast';

# };

# feature 'storage:s3', 'Amazon Web Services, currently only S3' => sub {
# feature 'storage:s3', 'AWS S3 compatible storage' => sub {
# support for the REST requests to the S3 storage
requires 'Mojolicious';

# support for S3 using Mojo::UserAgent
requires 'Mojolicious::Plugin::AWS';

Expand Down

0 comments on commit f61ef5e

Please sign in to comment.