Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: No extra RUN command for installing Net::DNS and Gazelle #1223

Closed
bschmalhofer opened this issue Sep 10, 2021 · 2 comments
Closed

Docker: No extra RUN command for installing Net::DNS and Gazelle #1223

bschmalhofer opened this issue Sep 10, 2021 · 2 comments
Assignees
Labels
tidying Tidying of the code
Milestone

Comments

@bschmalhofer
Copy link
Contributor

In otobo.web.dockerfile there are the following TODO comments:

# The modules Net::DNS and Gazelle take a long time to build and test.
# Install them early in a separate RUN in order to make rebuilds faster.
# TODO: go back to install via the cpanfile
#
# Found no easy way to install with --force in the cpanfile. Therefore install
# the modules with ignorable test failures with the option --force.
# TODO: go back to install via the cpanfile

Now that Carton is used for module installation, let's investigate whether these special cases are still needed. If they still make sense, then remove the TODO.

@bschmalhofer bschmalhofer added the tidying Tidying of the code label Sep 10, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.13 milestone Sep 10, 2021
@bschmalhofer bschmalhofer self-assigned this Sep 10, 2021
bschmalhofer added a commit that referenced this issue Sep 10, 2021
bschmalhofer added a commit that referenced this issue Sep 10, 2021
Issue #1223: do not install modules with cpanm
@bschmalhofer
Copy link
Contributor Author

Removed the explicit calls of cpanm. Build seems to be a little bit faster, as carton skips the tests. Github actions are still working. Closing this issue.

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Sep 12, 2021

Reopening because there are missing modules in rel-10_1.

There is a bit of confusion about how modules are declared in bin/otobo.CheckModules.pl. The current convention is that a module declaration needs exactly one of the attributes 'Required' or 'Features'. The hashes %IsStandardFeature and %IsDockerFeature then determine the specific behaviors under the various command line options.

bschmalhofer added a commit that referenced this issue Sep 12, 2021
Because it is part of the distro Plack.
bschmalhofer added a commit that referenced this issue Sep 12, 2021
…n_rel_10_1

Issue #1223 missing modules in rel 10 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidying Tidying of the code
Projects
None yet
Development

No branches or pull requests

1 participant