Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: Accept "((OTRS)) Community Edition" in RELEASE #1317

Closed
bschmalhofer opened this issue Oct 14, 2021 · 5 comments
Closed

Migration: Accept "((OTRS)) Community Edition" in RELEASE #1317

bschmalhofer opened this issue Oct 14, 2021 · 5 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.0.14

Comments

@bschmalhofer
Copy link
Contributor

This issue came up in the OTOBO forum: https://otobo.de/de/forums/topic/migration-von-otrs-6-zu-otobo/#post-12020.
It looks like some installations specify the product as ((OTRS)) Community Edition.
This setting should also be accepted in the check OTOBOFrameworkVersionCheck.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Oct 14, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.14 milestone Oct 14, 2021
@bschmalhofer bschmalhofer self-assigned this Oct 14, 2021
@bschmalhofer
Copy link
Contributor Author

Check the OTRS fork provided by Centuran. They switched the product name to ((OTRS)) Community Edition.
See Centuran/OTRS-Community-Edition@44710eb#diff-cdb88be95868ad8159c0c18868e8ea19f4376408fb9ba8e7325d1d923ae38069.

bschmalhofer added a commit that referenced this issue Oct 15, 2021
@bschmalhofer
Issue #1317: tidying
d0d3867 
No need for the intermediate variables %Result.
bschmalhofer added a commit that referenced this issue Oct 15, 2021
@bschmalhofer
Issue #1317: add checks for PRODUCT and VERSION
c7352ee 
whether they were found in RELEASE at all
bschmalhofer added a commit that referenced this issue Oct 15, 2021
@bschmalhofer
Issue #1317: Allow ((OTRS)) Community Edition as product name
2b9611a 
a more verbose message when there is a mismatch
bschmalhofer added a commit that referenced this issue Oct 15, 2021
@bschmalhofer
Merge pull request #1324 from RotherOSS/issue-#1317-otrscommunityedition
dfff897 
Issue #1317 otrscommunityedition
@bschmalhofer
Copy link
Contributor Author

Enhanced the OTOBOFrameworkVersionCheck and added a more informative message when there is an unknown product name.

TODO:

  • do a quick sanity check

bschmalhofer added a commit that referenced this issue Oct 15, 2021
@bschmalhofer
Issue #1317: synchronise mit new version in rel-10_1 branch
a07956d
bschmalhofer added a commit that referenced this issue Oct 15, 2021
@bschmalhofer
Issue #1317: explicit checks for VERSION and PRODUCT
ec4d404
bschmalhofer added a commit that referenced this issue Oct 15, 2021
@bschmalhofer
Merge pull request #1326 from RotherOSS/issue-#1317-sync_with_10_1
84c5c89 
Issue #1317 sync with 10 1
@bschmalhofer
Copy link
Contributor Author

Found that there were already changes for OTOBOFrameworkVersionCheck in the rel-10_1 branch. Consolidating these separate changes.

@bschmalhofer
Copy link
Contributor Author

No complaints so far. closing this issue.

@bschmalhofer
Copy link
Contributor Author

There is a bug in line 212 of Kernel/System/MigrateFromOTRS/OTOBOFrameworkVersionCheck.pm. The check is for OTOBO 10.1 while it should check for 10.0. The culprit was the commit a07956d, a07956d .

This bug was reported in the OTOBO Forum:
https://otobo.de/en/forums/topic/fehler-bei-der-vorpruefungen-zur-migration/

@bschmalhofer bschmalhofer mentioned this issue Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.0.14
Development

No branches or pull requests
1 participant
@bschmalhofer