Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel::System::Package: remove compatability to OTRS 2.2 #1364

Closed
bschmalhofer opened this issue Oct 27, 2021 · 4 comments
Closed

Kernel::System::Package: remove compatability to OTRS 2.2 #1364

bschmalhofer opened this issue Oct 27, 2021 · 4 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

There is still some support for OTRS 2.2 style packages in Kernel/System/Package.pm. I think that this is no longer needed.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Oct 27, 2021
@bschmalhofer bschmalhofer added this to the Wishlist milestone Oct 27, 2021
@svenoe
Copy link
Contributor

svenoe commented Oct 28, 2021

Can be removed. We don't offer full compatibility to OTRS packages, even though some work out of the box, more or less. 2.2 is so old, that having a look at them is a good idea anyways, probably...

@bschmalhofer bschmalhofer self-assigned this Oct 28, 2021
@bschmalhofer bschmalhofer modified the milestones: Wishlist, OTOBO 10.1 Oct 28, 2021
@bschmalhofer
Copy link
Contributor Author

Can be done after the current changes for #1362 are merged.

bschmalhofer added a commit that referenced this issue Nov 2, 2021
@bschmalhofer
Issue #1364: tidying
9599f67
bschmalhofer added a commit that referenced this issue Nov 2, 2021
@bschmalhofer
Issue #1364: use postfix dereferencing
aa31c15 
just for making the code more sane
bschmalhofer added a commit that referenced this issue Nov 2, 2021
@bschmalhofer
Issue #1364: remove compatability workarounds for OTRS 2.2
f7fa3dd
@bschmalhofer
Copy link
Contributor Author

Removed the workarounds for OTRS 2.2. Plus a bit of tidying.

Closing the issue only when the unit tests look fine.

bschmalhofer added a commit that referenced this issue Nov 2, 2021
@bschmalhofer
Merge branch 'rel-10_1' into issue-#1364-otrs_2_2
c7d7058
bschmalhofer added a commit that referenced this issue Nov 2, 2021
@bschmalhofer
Merge pull request #1379 from RotherOSS/issue-#1364-otrs_2_2
6045bdc 
Issue #1364 otrs 2 2
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 4, 2021
@bschmalhofer
Copy link
Contributor Author

Test suite looked fine. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
2 participants
@bschmalhofer @svenoe