Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow advice from hadolint on otobo.web.dockerfile #1375

Closed
bschmalhofer opened this issue Nov 1, 2021 · 1 comment
Closed

Follow advice from hadolint on otobo.web.dockerfile #1375

bschmalhofer opened this issue Nov 1, 2021 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.0.14

Comments

@bschmalhofer
Copy link
Contributor

Hadolint says:

bes:~/devel/OTOBO/otobo (issue-#1362-watchdog_loops)$ bin/docker/lint_docker_files.sh
Linting otobo.web.dockerfile
-:63 DL3059 info: Multiple consecutive RUN instructions. Consider consolidation.

Reducing the number of images is a good idea. Let's consolidate.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Nov 1, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.14 milestone Nov 1, 2021
@bschmalhofer bschmalhofer self-assigned this Nov 1, 2021
bschmalhofer added a commit that referenced this issue Nov 1, 2021
@bschmalhofer
Issue #1375: combine three RUN into a single RUN
6c43e1f 
as recommended by hadolint
bschmalhofer added a commit that referenced this issue Nov 1, 2021
@bschmalhofer
Merge pull request #1376 from RotherOSS/issue-#1375-hadolint
30f2741 
Issue #1375: combine three RUN into a single RUN
@bschmalhofer
Copy link
Contributor Author

The advice from hadolint is gone. A quick sanity check looked fine. Closing this issue.

bschmalhofer added a commit that referenced this issue Jan 19, 2023
@bschmalhofer
Merge branch 'rel-10_1' into rel-#1375-hadolint
3bfd1b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.0.14
Development

No branches or pull requests
1 participant
@bschmalhofer