Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt mtime checks to S3 support for the MinIO case #1744

Closed
bschmalhofer opened this issue Apr 30, 2022 · 1 comment
Closed

Adapt mtime checks to S3 support for the MinIO case #1744

bschmalhofer opened this issue Apr 30, 2022 · 1 comment
Assignees
@bschmalhofer
Milestone
OTOBO 10.1.5

Comments

@bschmalhofer
Copy link
Contributor

The ListObjects method of MinIO reports the time in second with milliseconds in the fractional part. But the existing checks of the mtime is done in seconds only. For getting accurate check cast both values as integer.
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Apr 30, 2022
@bschmalhofer bschmalhofer self-assigned this Apr 30, 2022
@bschmalhofer bschmalhofer changed the title Adapt mtime checks to MinIO Adapt mtime checks to S3 support for the MinIO case Apr 30, 2022
bschmalhofer added a commit that referenced this issue Apr 30, 2022
@bschmalhofer
Issue #1744: cast the mtime to full seconds
c2c4715 
before comparing values
bschmalhofer added a commit that referenced this issue Apr 30, 2022
@bschmalhofer
Merge pull request #1746 from RotherOSS/issue-#1744-milliseconds
4ef5d8d 
Issue #1744: cast the mtime to full seconds
@bschmalhofer
Copy link
Contributor Author

PR is merged. Tesing was done in a customer project. Closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.5 Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
None yet
Projects
None yet
Milestone
OTOBO 10.1.5
Development

No branches or pull requests
1 participant
@bschmalhofer