Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check documentation of cron tasks #1761

Closed
2 tasks done
bschmalhofer opened this issue May 6, 2022 · 2 comments
Closed
2 tasks done

Check documentation of cron tasks #1761

bschmalhofer opened this issue May 6, 2022 · 2 comments
Assignees
@bschmalhofer
Labels
daemon Related to the OTOBO daemon tidying Tidying of the code
Milestone
OTOBO 10.1.5

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented May 6, 2022 •
edited
Loading

There is another thing I noticed while trying to find out what the OTOBO Daemon does. The description of the tasks in Daemon::SchedulerCronTaskManager::Task do not always reflect reality. Some examples are:

  • StatsReportsGenerateCron does not clean up chat logs
  • CoreCacheCleanup is not limited to core modules, whatever is meant by core modules

TODO:

  • check the descriptions in the Kernel/Config/Files/XML/*.xml files
  • also check the POD of the relevant modules while we are at it

Originally posted by @bschmalhofer in #1755 (comment)
@bschmalhofer bschmalhofer self-assigned this May 6, 2022
@bschmalhofer bschmalhofer added the tidying Tidying of the code label May 6, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.5 milestone May 6, 2022
@bschmalhofer bschmalhofer added the daemon Related to the OTOBO daemon label May 6, 2022
@bschmalhofer
Copy link
Contributor Author

@svenoe : I was thinking of fixing the spelling error in the cron task Daemon::SchedulerCronTaskManager::Task###GeneticInterfaceDebugLogCleanup. But I'm hesitant because that would be a significant change. What do you think?

bschmalhofer added a commit that referenced this issue May 7, 2022
@bschmalhofer
Issue #1761: Capitalize LDAP, as it is an acronym.
d8c0f89
bschmalhofer added a commit that referenced this issue May 7, 2022
@bschmalhofer
Issue #1761: Fix description of StatsReportsGenerateCron.
c4e31dc
bschmalhofer added a commit that referenced this issue May 7, 2022
@bschmalhofer
Issue #1761: also mention that PreRun() and PostRun() are called
95e5dfd
bschmalhofer added a commit that referenced this issue May 7, 2022
@bschmalhofer
Issue #1761: remove remains of debug sessions
eda1d25
bschmalhofer added a commit that referenced this issue May 7, 2022
@bschmalhofer
Issue #1761: fix spelling: noting -> nothing
7de3c25 
Much ado about noting.
bschmalhofer added a commit that referenced this issue May 7, 2022
@bschmalhofer
Issue #1761: fix grammar in POD
d0090e8
bschmalhofer added a commit that referenced this issue May 7, 2022
@bschmalhofer
Issue #1761: spelling: otobo.console.pl -> otobo.Console.pl
0bc2213
bschmalhofer added a commit that referenced this issue May 7, 2022
@bschmalhofer
Merge pull request #1763 from RotherOSS/issue-#1761-cron_task_documen…
1fa965d 
…tation

Issue #1761 cron task documentation
@bschmalhofer
Copy link
Contributor Author

Didn't find any more documentation glitches, but fixed some spelling errors. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
daemon Related to the OTOBO daemon tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.5
Development

No branches or pull requests
1 participant
@bschmalhofer