Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set @INC in modules #222

Closed
bschmalhofer opened this issue Jul 20, 2020 · 1 comment
Closed

Do not set @INC in modules #222

bschmalhofer opened this issue Jul 20, 2020 · 1 comment
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

At least be careful about it. $FindBin::Bin is dangerous because one can't be sure about the location of the calling script.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Jul 20, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 20, 2020
@bschmalhofer bschmalhofer self-assigned this Jul 20, 2020
bschmalhofer added a commit that referenced this issue Jul 20, 2020
@bschmalhofer
Issue #222: no tampering with @inc in Kernel/Config/Defaults.pm
6fc8f87
bschmalhofer added a commit that referenced this issue Jul 20, 2020
@bschmalhofer
Merge pull request #223 from RotherOSS/issue-222-no_use_lib_in_modules
9f61085 
Issue #222: no tampering with @inc in Kernel/Config/Defaults.pm
@bschmalhofer
Copy link
Contributor Author

Remove the setting of @INCin Kernel/Config/Defaults.pm. No other occurences found. Closing.

@bschmalhofer bschmalhofer mentioned this issue Sep 29, 2020
Closed
bschmalhofer added a commit that referenced this issue Sep 29, 2020
@bschmalhofer
Issue #486: do not mess with @inc in modules
7ede4e0 
Backport the fix from #222.
@bschmalhofer bschmalhofer mentioned this issue Sep 29, 2020
Merged
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer