Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up mentions of OTOBO 5 and OTOBO 6 #232

Closed
bschmalhofer opened this issue Jul 22, 2020 · 7 comments
Closed

Clean up mentions of OTOBO 5 and OTOBO 6 #232

bschmalhofer opened this issue Jul 22, 2020 · 7 comments
Assignees
@bschmalhofer @svenoe @StefanRother-OTOBO
Labels
question Further information is requested
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jul 22, 2020 •
edited
Loading

In these cases it can be presumed that either legacy version of OTRS or OTOBO 10 is meant.
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 22, 2020
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jul 22, 2020 •
edited
Loading

In the migration modules and tests there are frequent mentions of OTOBO 5 and OTOBO 6. This is confusing as OTOBO starts with Version 10.
I checked with the following commands:

  • grep -r -i 'otobo\s*[0123456789]' . | grep -v -i 'otobo\s*10'
  • find . -iname '*OTOBO[0123456789]*'

I could do the renaming, but I would need some clarification concerning the migration pathes. OTRS 5 => OTOBO 10 vs, OTRS 6 => OTOBO 10.

@bschmalhofer
Copy link
Contributor Author

Note that the only relevant migration is from OTRS 6 to OTOBO 10.

bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: Migration is from OTRS 6 to OTOBO 10.
4252869 
In OTRS 6 the xml files are already in the folder XML.
Therefore don't put the migrated files into the subdir 'XML'.
Instead create a backup file.
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: simplify the constructor
560f700
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: remove DESTROY.
4a2d090 
Just because the log message is not really needed and DESTROY()
is a potential source of errors.
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: remove not needed object dependency
995acf1
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: factor out Kernel::System::SysConfig::Migration::MigrateX…
88fd6bc 
…MLStructure()

Only the renaming of the root tag remains.
Everything else concerned only OTRS 5 to OTRS 6.
Added a test case for Dev::Tools::Migrate::ConfigXMLStructur
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: remove Kernel::System::SysConfig::Migration
3daa51d 
This module was only concerned about OTRS 5 -> OTRS 6 migration
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: Upgrade from OTRS 5 is no longer a relevant case.
44e05a4
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: update test description
06fd88e 
Added reference to #362.
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issze #232: there never was a OTOBO 1.1
25579ed
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: there never was a OTOBO 2.1
82f5810
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: There never was OTOBO 3
2f38c0e
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: there never was OTOBO 4
67b3d3b
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #232: there never was an OTOBO 6
5c5265a
@bschmalhofer
Copy link
Contributor Author

The UnitTests look fine. Closing.

@bschmalhofer bschmalhofer mentioned this issue Aug 17, 2020
Closed
@bschmalhofer bschmalhofer added the question Further information is requested label Sep 28, 2020
@bschmalhofer
Copy link
Contributor Author

Should this be backported to the rel-10_0 branch? Already for 10.0.4 ?

bschmalhofer added a commit that referenced this issue Sep 28, 2020
@bschmalhofer
Issue #447: remove two obsolete test scripts.
f1f410b 
See #232
@bschmalhofer bschmalhofer reopened this Sep 28, 2020
@bschmalhofer bschmalhofer mentioned this issue Sep 29, 2020
Closed
@StefanRother-OTOBO
Copy link
Contributor

Hi,

I think this UnitTests are for migration OTRS 5 to 6, cause I do not create UnitTests for migrating to OTOBO yet.
For me it's fine to remove the tests.

Thanks,

Stefan

bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: Migration is from OTRS 6 to OTOBO 10.
6682fbd 
In OTRS 6 the xml files are already in the folder XML.
Therefore don't put the migrated files into the subdir 'XML'.
Instead create a backup file.
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: simplify the constructor
f9cec89
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: remove DESTROY.
d189414 
Just because the log message is not really needed and DESTROY()
is a potential source of errors.
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: remove not needed object dependency
8de92f9
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: factor out Kernel::System::SysConfig::Migration::MigrateX…
83924b9 
…MLStructure()

Only the renaming of the root tag remains.
Everything else concerned only OTRS 5 to OTRS 6.
Added a test case for Dev::Tools::Migrate::ConfigXMLStructur
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: remove Kernel::System::SysConfig::Migration
8a3225b 
This module was only concerned about OTRS 5 -> OTRS 6 migration
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: Upgrade from OTRS 5 is no longer a relevant case.
5eab06c
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: update test description
ba3aeeb 
Added reference to #362.
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issze #232: there never was a OTOBO 1.1
ca4fbbf
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: there never was a OTOBO 2.1
0be3e29
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: There never was OTOBO 3
643a29f
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: there never was OTOBO 4
c4e3703
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #232: there never was an OTOBO 6
f43137d
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #447: remove two obsolete test scripts.
f84af04 
See #232
@bschmalhofer
Copy link
Contributor Author

I cherry-picked the commits for this branch into the rel-10_0 branch. Let's close this issue again when things look fine again. There might be some fallout from resolving the merge conflicts.

bschmalhofer added a commit that referenced this issue Oct 14, 2020
@bschmalhofer
Issue #232: fix contributor otobo365.com -> otrs365.com
f39ed92
bschmalhofer added a commit that referenced this issue Oct 14, 2020
@bschmalhofer
Merge pull request #546 from RotherOSS/issue-#232-OTRS365
09d2412 
Issue #232: fix contributor otobo365.com -> otrs365.com
@bschmalhofer
Copy link
Contributor Author

Did a final check on rel-10_0 and repaired info@otrs365.com. Closing this issue again.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

@svenoe svenoe

@StefanRother-OTOBO StefanRother-OTOBO

Labels
question Further information is requested
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
3 participants
@bschmalhofer @svenoe @StefanRother-OTOBO