Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel::System::CronEvent produces invalid local times #238

Closed
bschmalhofer opened this issue Jul 22, 2020 · 1 comment
Closed

Kernel::System::CronEvent produces invalid local times #238

bschmalhofer opened this issue Jul 22, 2020 · 1 comment
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.0.3

Comments

@bschmalhofer
Copy link
Contributor

The daylight saving switch is problematic. See scripts/test/CronEvent.t .
It is not obvious what the correct behavior is. Needs to be investigated.
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Jul 22, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 22, 2020
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.0.3 Aug 19, 2020
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #238: pull in some changes from rel-10_1
4538f73
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #238: use OTOBOTimeZoneGet() instead of OTRSTimeZoneGet()
8fdba24
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #238: enable the commented out tests
ec58661 
Saner name for the arrays containing the test cases.
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #238: DoneTesting() is called automatically in the 10_0 branch
d8f86bc
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #238: adapt the expected output of a test
4eff83b 
did the counting manually
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #238: implement the UTC-workaround for PreviousEventGet()
17fd3ed 
Just like in NextEventGet()
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #238: do the UTC workaround for NextEventList().
398744d
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #238: sync the required modules between 10_1 and 10_0
14a19f8 
Just to make the builds faster.
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Merge pull request #379 from RotherOSS/issue-238-modules
d1e3546 
Issue #238: sync the required modules between 10_1 and 10_0
@bschmalhofer
Copy link
Contributor Author

Dates must be converted to UTC before, and be converted to OTOBOTimeZone after, Scheduler::Cron::Event kicks in. This has not been implemented for all the relevant function. Things look good after adding the conversions. Closing.

@bschmalhofer bschmalhofer mentioned this issue Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.0.3
Development

No branches or pull requests
1 participant
@bschmalhofer