Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable REQUEST_SCHEME is not reliable #395

Closed
3 tasks done
bschmalhofer opened this issue Aug 25, 2020 · 1 comment
Closed
3 tasks done

Environment variable REQUEST_SCHEME is not reliable #395

bschmalhofer opened this issue Aug 25, 2020 · 1 comment
Assignees
Labels
bug Something isn't working as intended
Milestone

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Aug 25, 2020

When testing migration.pl under Docker via HTTP I found that there is no warning about using HTTP
The cause seems to be that the env var REQUEST_SCHEME is not set when running unter Gazelle.

grep -r REQUEST_SCHEME .
./Kernel/Output/HTML/Templates/Standard/MigrateFromOTRS/Intro.tt:[% IF Env("REQUEST_SCHEME") == 'http' %]

This is expected as the source of that info should be $ParamObject->HTTPS('HTTPS').

A related effect is that on the Intro page of migration.pl the 'Continue' button is not visible when runnung under Gazelle.

TODO:

  • Handle the check HTTP vs. HTTPS the same way as in Kernel::Modules::Installer.

  • Test with HTTP

  • Test with HTTPS

@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Aug 25, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Aug 25, 2020
@bschmalhofer bschmalhofer self-assigned this Aug 25, 2020
bschmalhofer added a commit that referenced this issue Aug 26, 2020
@bschmalhofer
Copy link
Contributor Author

Continue button is now visible under HTTP and HTTPS. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant