Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrateFromOTRS: handle Blob columns #601

Closed
bschmalhofer opened this issue Oct 31, 2020 · 2 comments
Closed

MigrateFromOTRS: handle Blob columns #601

bschmalhofer opened this issue Oct 31, 2020 · 2 comments
Assignees
Labels
bug Something isn't working as intended duplicate This issue or pull request already exists
Milestone

Comments

@bschmalhofer
Copy link
Contributor

It looks like Blob Columns were never correctly converted between dabase types that have different DirectBlob settings.
Either fix this, or remove the remnants of the code that once did the conversion.

Maybe check whether there still is a need to support Base64 encoded binary data.

@bschmalhofer
Copy link
Contributor Author

I added support for Blob conversion in Kernel::System::MigrateFromOTRS::CloneDB::Driver::Base in the rel-10_0 branch. This should not affect MySQL to MySQL migration, as the DB::DirectBlob check is still honored.

However it looks like the conversion is not as straightforward as assumed. Let's take for example the table columns article_data_mime.email and sysconfig_default_version.description. For the first column there is an explicit check of DB::DirectBlob in Kernel::System::Ticket::Article::Backend::MIMEBase::ArticleStorageDB.

    # encode attachment if it's a postgresql backend!!!
    if ( !$DBObject->GetDatabaseFunction('DirectBlob') ) {

        $Kernel::OM->Get('Kernel::System::Encode')->EncodeOutput( \$Param{Email} );

        $Param{Email} = encode_base64( $Param{Email} );
    }

But, for the latter column, there seems to be no such check in Kernel::System::SysConfig::DB.

This seems to indicate that some more testing of the PostgreSQL to MySQL migration needs to be done. As this is not super urgent, let's move the issue to OTOBO 10.1.x.

@StefanRother-OTOBO
Copy link
Contributor

Dublicate with Issue #1006, #800 and #601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants