Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove method Kernel::Output::HTML::Layout::_RemoveScriptTags() #606

Closed
bschmalhofer opened this issue Nov 2, 2020 · 2 comments
Closed

Remove method Kernel::Output::HTML::Layout::_RemoveScriptTags() #606

bschmalhofer opened this issue Nov 2, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

This method seems to be unused. I propose to remove it.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Nov 2, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Nov 2, 2020
@bschmalhofer bschmalhofer self-assigned this Feb 26, 2021
@bschmalhofer
Copy link
Contributor Author

Judging from OTRS/otrs@180e560 it looks like this sub was used for handling dtl-Templates. dtl-Templates are no longer used, so I surmise that this unused sub can safely be removed.

bschmalhofer added a commit that referenced this issue Feb 26, 2021
@bschmalhofer
Issue #606: remove _RemoveScriptTags()
a129917 
Satisfy the CodePolicy().
But do not accept all suggestions from Perl::Tidy.
@bschmalhofer
Copy link
Contributor Author

The method is removed, CodePolicy is almost satisfied. Closing this issue.

bschmalhofer added a commit that referenced this issue Feb 26, 2021
@bschmalhofer
Merge pull request #823 from RotherOSS/issue-#606-_RemoveScriptTags
9f042c3 
Issue #606: remove _RemoveScriptTags()
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer