Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium Testing: TODO comment about SuppressFrames #706

Closed
2 tasks done
bschmalhofer opened this issue Jan 7, 2021 · 1 comment
Closed
2 tasks done

Selenium Testing: TODO comment about SuppressFrames #706

bschmalhofer opened this issue Jan 7, 2021 · 1 comment
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended selenium Related to fixing or improving testing with Selenium
Milestone
OTOBO 10.0.7

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jan 7, 2021 •
edited
Loading

In _Kernel/System/UnitTest/Selenium.pm _ there is following content:

             # TODO: this needs to be adapted
             $SuppressFrames++ if $_[0]->{caller}->[3] eq 'Kernel::System::UnitTest::Driver::Run';

TODO:

  • check whether frames are suppressed correctly
  • check whether Test2::V0 frames can be suppressed too
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Jan 7, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.7 milestone Jan 7, 2021
@bschmalhofer bschmalhofer self-assigned this Jan 7, 2021
bschmalhofer added a commit that referenced this issue Jan 7, 2021
@bschmalhofer
Issue #706: simplify the strategy which frames are skipped
4317951 
Not sure whether this is the best approach, as the
Selenium method is not shown.
bschmalhofer added a commit that referenced this issue Jan 7, 2021
@bschmalhofer
Issue #706: early exit in RunTest()
1a6850a
bschmalhofer added a commit that referenced this issue Jan 7, 2021
@bschmalhofer
Merge pull request #708 from RotherOSS/issue-#706-suppress_frames
44d5eb0 
Issue #706 suppress frames
@bschmalhofer
Copy link
Contributor Author

Rule for skipping frames in the stack trace should now be independent of the testing subroutine.

@bschmalhofer bschmalhofer added the selenium Related to fixing or improving testing with Selenium label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended selenium Related to fixing or improving testing with Selenium
Projects
None yet
Milestone
OTOBO 10.0.7
Development

No branches or pull requests
1 participant
@bschmalhofer