-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fallback support for CGI in Kernel::System::Web::Request #761
Comments
Issue #761: remove the fallback to CGI
The fallback has been removed. Let's wait for the next run of the Selenium tests before closing the issue. |
At least some Selenium-Tests are succeeding with the branch rel-10_1 . Closing this issue. |
Reopen because there are many failures in the test suite becaus of this change, Needs to be investigated. |
Make sure that Kernel::System::Web::Request has a WebRequest as constructor param.
Script still worked after tidying.
where a request is actually set up
Looks like there are too many dependencies that rely on instantiating Kernel::System::Web::Request without passing a CGI object. Therefore fall back on an an empty CGI object.
|
…estscript Issue #761: give the new CGI object to the object manager
Running the test suite with rel-10_1 looks fine. Only Selenium errors pop up. Closing this issue again. |
In Kernel::System::Web::Request there are following lines:
I don't see any sensible use case for that fallback. Let's remove it then.
The text was updated successfully, but these errors were encountered: