Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallback support for CGI in Kernel::System::Web::Request #761

Closed
bschmalhofer opened this issue Jan 30, 2021 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bschmalhofer
Copy link
Contributor

In Kernel::System::Web::Request there are following lines:

    # CGI via the %ENV hash is still supported as a fallback
    else {
        $Self->{Query} = CGI->new();
    }

I don't see any sensible use case for that fallback. Let's remove it then.

@bschmalhofer bschmalhofer added the enhancement New feature or request label Jan 30, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jan 30, 2021
@bschmalhofer bschmalhofer self-assigned this Feb 6, 2021
bschmalhofer added a commit that referenced this issue Feb 6, 2021
@bschmalhofer
Copy link
Contributor Author

The fallback has been removed. Let's wait for the next run of the Selenium tests before closing the issue.

@bschmalhofer
Copy link
Contributor Author

At least some Selenium-Tests are succeeding with the branch rel-10_1 . Closing this issue.

@bschmalhofer
Copy link
Contributor Author

Reopen because there are many failures in the test suite becaus of this change, Needs to be investigated.

@bschmalhofer bschmalhofer reopened this Feb 28, 2021
bschmalhofer added a commit that referenced this issue Mar 1, 2021
Make sure that Kernel::System::Web::Request has a WebRequest as constructor param.
bschmalhofer added a commit that referenced this issue Mar 1, 2021
Script still worked after tidying.
bschmalhofer added a commit that referenced this issue Mar 1, 2021
bschmalhofer added a commit that referenced this issue Mar 1, 2021
where a request is actually set up
bschmalhofer added a commit that referenced this issue Mar 1, 2021
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Mar 1, 2021

Looks like there are too many dependencies that rely on instantiating Kernel::System::Web::Request without passing a CGI object. Therefore fall back on an an empty CGI object.
Some tests scripts do want to pass a request to the ParamObject. Pass CGI->new() in those cases.
TODO:

  • run test suite again

bschmalhofer added a commit that referenced this issue Mar 1, 2021
bschmalhofer added a commit that referenced this issue Mar 2, 2021
…estscript

Issue #761: give the new CGI object to the object manager
@bschmalhofer
Copy link
Contributor Author

Running the test suite with rel-10_1 looks fine. Only Selenium errors pop up. Closing this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant