Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perl::Critiic: do not violate ValuesAndExpressions::ProhibitCommaSeparatedStatements #795

Closed
bschmalhofer opened this issue Feb 14, 2021 · 1 comment
Closed

Perl::Critiic: do not violate ValuesAndExpressions::ProhibitCommaSeparatedStatements #795

bschmalhofer opened this issue Feb 14, 2021 · 1 comment

Comments

@bschmalhofer
Copy link
Contributor

The policy https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements might hint at real errors. Make sure that there are no violations of that policy.

Originally posted by @bschmalhofer in #760 (comment)
@bschmalhofer bschmalhofer changed the title Perl::Critiic: do not violate ValuesAndExpressions::ProhibitCommaSeparatedStatements might hint at real errors. Make sure that there are no violations of that policy. Perl::Critiic: do not violate ValuesAndExpressions::ProhibitCommaSeparatedStatements Feb 14, 2021
bschmalhofer added a commit that referenced this issue Feb 14, 2021
@bschmalhofer
Issue #795: avoid violation of ProhibitCommaSeparatedStatements
c38e739 
The violations in TicketGet.t were most likely false positive.
Maybe PPI got confused with the nested data structure.
Worked around by adding a + before hashrefs.
bschmalhofer added a commit that referenced this issue Feb 14, 2021
@bschmalhofer
Merge pull request #797 from RotherOSS/issue-795-ProhibitCommaSeparat…
a6ec12b 
…edStatements

Issue #795: avoid violation of ProhibitCommaSeparatedStatements
@bschmalhofer
Copy link
Contributor Author

Nothing really bad was found. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bschmalhofer