Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make *prove scripts/tests" work. #87

Closed
bschmalhofer opened this issue Jun 14, 2020 · 3 comments
Closed

Make *prove scripts/tests" work. #87

bschmalhofer opened this issue Jun 14, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone
OTOBO 10.0.1

Comments

@bschmalhofer
Copy link
Contributor

Why can't I simply call prove scripts/tests for running the tests?
@bschmalhofer
Copy link
Contributor Author

This works somewhat now. However there are still strange effects, deep recursion during global destruction, when calling
perl -I . -I Kernel/cpan-lib/ scripts/test/LayoutTicket.t .
Other scripts
perl -I . -I Kernel/cpan-lib/ scripts/test/LayoutTicket.t .
seem to work without much recursion.

bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: added the most basic test script
033fa28 
A script that does not use Kernel::System::UnitTest.
Currently not getting along with Dev::UnitTest::Run
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: Clarify that Dev::UnitTest::Run should ignore this test sc…
be84e1e 
…ript
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: tidying
c07e718
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: emit a dummy test plan,
068df7e 
at least when Kernel::System::UnitTest::Helper is used
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: remove the leading space before 'ok' and 'not ok'
26da672 
The leading space does not conform to TAP.
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: Start with support for running scripts as regular perl scr…
6ad9b69 
…ipts.
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: do not set @inc
dd97b8b 
whoever is running the test scripts is responsible for setting up @inc
I suppose this is the most flexible approach.
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: conditionally load 'Kernel::System::UnitTest::RegisterDriver'
c6a1baf 
This sets up $Self in the current package.
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: Added DomeTesting().
1623e28 
For those scripts that don't have a Helper object.
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: ignore temporary files during testing
9a7579a
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: No longer use Exporter
0152ed6 
Trying to simplify.
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: break infinite loop
c1776f2 
This happened when no DateTime object could be created during global destruction.
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: use the current_sub feature.
cc510c2 
See https://perldoc.perl.org/feature.html#The-'current_sub'-feature
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: do the cleanup and print the plan in an END block.
1bbc190 
Trying to replicate the behavior in Dev::UnitTest::Run
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: work on the POD and on the code comments
937dc48
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: undef $main::Helper is useless
ce76946 
as $Helper is usually a lexical var in the test scripts
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: the 'no strict' pragma is lexically scoped.
44b841a 
No need to turn it back on with 'use strict'
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: avoid some warnings.
408c142
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: avoid a return in script.
fd30526 
This is nasty, as there is no problem with Dev::UnitTest::Run
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: Guard to prevent cleanup in fork processes.
a7f0bb6 
This should satisfy scripts/test/AsynchronousExecutor.t
bschmalhofer added a commit that referenced this issue Jun 30, 2020
@bschmalhofer
Issue #87: make the END block a closure
3e1d548 
Less action at a distance.
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: added the most basic test script
e1d241a 
A script that does not use Kernel::System::UnitTest.
Currently not getting along with Dev::UnitTest::Run
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: Clarify that Dev::UnitTest::Run should ignore this test sc…
5c9e600 
…ript
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: tidying
8e956ae
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: emit a dummy test plan,
bebb580 
at least when Kernel::System::UnitTest::Helper is used
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: remove the leading space before 'ok' and 'not ok'
0e1940b 
The leading space does not conform to TAP.
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: Start with support for running scripts as regular perl scr…
53defa9 
…ipts.
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: do not set @inc
85f7949 
whoever is running the test scripts is responsible for setting up @inc
I suppose this is the most flexible approach.
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: conditionally load 'Kernel::System::UnitTest::RegisterDriver'
48ceadb 
This sets up $Self in the current package.
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: Added DomeTesting().
63ef208 
For those scripts that don't have a Helper object.
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: ignore temporary files during testing
0b4b493
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: No longer use Exporter
c8780bd 
Trying to simplify.
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: break infinite loop
e730e82 
This happened when no DateTime object could be created during global destruction.
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: use the current_sub feature.
8350bee 
See https://perldoc.perl.org/feature.html#The-'current_sub'-feature
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: do the cleanup and print the plan in an END block.
aec31e1 
Trying to replicate the behavior in Dev::UnitTest::Run
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: work on the POD and on the code comments
ec6b0ed
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: undef $main::Helper is useless
525910f 
as $Helper is usually a lexical var in the test scripts
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: the 'no strict' pragma is lexically scoped.
39a7e7a 
No need to turn it back on with 'use strict'
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: avoid some warnings.
8e408d1
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: avoid a return in script.
1cfc8db 
This is nasty, as there is no problem with Dev::UnitTest::Run
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: Guard to prevent cleanup in fork processes.
bce3243 
This should satisfy scripts/test/AsynchronousExecutor.t
bschmalhofer added a commit that referenced this issue Jul 1, 2020
@bschmalhofer
Issue #87: make the END block a closure
18d1d4f 
Less action at a distance.
@bschmalhofer bschmalhofer added this to the OTOBO 10.0 milestone Jul 2, 2020
@bschmalhofer bschmalhofer added the enhancement New feature or request label Jul 2, 2020
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jul 7, 2020 •
edited
Loading

Note: For testing in the otobo_web_1 container the Elasticsearch webservice needs to be deactivated.

Testing can be done with:

prove -I . -I Kernel/cpan-lib -r --verbose scripts/test/ > prove_verbose.out 2>&1

TODO:

  • Check whether tests outcome get better or faster when the Daemon is not running

  • Still some instances of: Can't return outside a subroutine

@bschmalhofer
Copy link
Contributor Author

It looks like shutting down the Daemon has no large effect.
Closing the issue now. Specific failures can be handled in dedicated issues.

@bschmalhofer bschmalhofer mentioned this issue Feb 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer