Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remnants of support for MacOS #997

Closed
bschmalhofer opened this issue May 9, 2021 · 2 comments
Closed

Remove remnants of support for MacOS #997

bschmalhofer opened this issue May 9, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

My understanding is that Mac OS is not supported by OTOBO. So, I think that it is sensible to remove remnants of support for MacOS, that is 'darwin'.

bes:~/devel/OTOBO/otobo (issue-#680-prohibit_open)$ grep -r -l darwin
Kernel/cpan-lib/Encode/Locale.pm
Kernel/cpan-lib/Sys/Hostname/Long.pm
Kernel/System/SupportDataCollector/Plugin/OS/KernelVersion.pm
Kernel/System/SupportDataCollector/Plugin/OS/DiskPartitionOTOBO.pm
Kernel/System/SupportDataCollector/Plugin/OS/Swap.pm
Kernel/System/SupportDataCollector/Plugin/OS/.Load.pm.swp
Kernel/System/SupportDataCollector/Plugin/OS/DiskSpace.pm
Kernel/System/SupportDataCollector/Plugin/OS/DiskSpacePartitions.pm
Kernel/System/SupportDataCollector/Plugin/OS/Load.pm
Kernel/System/Environment.pm
scripts/test/Package.t
@bschmalhofer
Copy link
Contributor Author

Discussed this with the Dev-Team. We concluded that the checks can go.

@bschmalhofer bschmalhofer self-assigned this Jun 10, 2021
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jun 10, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jun 10, 2021
bschmalhofer added a commit that referenced this issue Jun 10, 2021
@bschmalhofer
Issue #997: remove checks for 'darwin'
7d73e5a
bschmalhofer added a commit that referenced this issue Jun 10, 2021
@bschmalhofer
Issue #997: specify the relevant issue
3d9722e 
in a TODO comment
bschmalhofer added a commit that referenced this issue Jun 10, 2021
@bschmalhofer
Merge pull request #1077 from RotherOSS/issue-#997-darwin
79f1c28 
Issue #997 darwin
@bschmalhofer
Copy link
Contributor Author

PR is merged. Support Data still looks sensible. Closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer