Skip to content

Commit

Permalink
Suppress -Wformat-truncation for older GCC (dotnet#101557)
Browse files Browse the repository at this point in the history
  • Loading branch information
am11 authored and Ruihan-Yin committed May 30, 2024
1 parent 9f40228 commit 9dcf89c
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions src/native/libs/System.Globalization.Native/pal_icushim.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,19 @@ static int FindSymbolVersion(int majorVer, int minorVer, int subVer, char* symbo
// First try just the unversioned symbol
if (dlsym(libicuuc, "u_strlen") == NULL)
{
// suppress Wformat-truncation false-positive warning for gcc 7 and 8
#if defined(__GNUC__) && __GNUC__ > 6 &&__GNUC__ < 9
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wformat-truncation"
#endif

// Now try just the _majorVer added
snprintf(symbolVersion, symbolVersionLen, "_%d%s", majorVer, suffix);

#if defined(__GNUC__) && __GNUC__ > 6 &&__GNUC__ < 9
#pragma GCC diagnostic pop
#endif

snprintf(symbolName, SYMBOL_NAME_SIZE, "u_strlen%s", symbolVersion);
if (dlsym(libicuuc, symbolName) == NULL)
{
Expand Down

0 comments on commit 9dcf89c

Please sign in to comment.