Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommending Case-Insensitive Search (i.e. for Model Hash) #131

Closed
tk101-fs opened this issue Jul 18, 2023 · 1 comment
Closed

Recommending Case-Insensitive Search (i.e. for Model Hash) #131

tk101-fs opened this issue Jul 18, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@tk101-fs
Copy link

It looks like some searches are case sensitive, which gives unexpectedly limited search results for some scenarios. For example, if an image metadata has a (notional) model hash of "abc123def", but I run a Model Hash search for "ABC123DEF", the image will not be found in the search. This is unexpected because the case of the ascii character should not matter -- the hash values are a segment from a SHA computation and while normally you find that written in all-CAPS, it appears some generation software writes the model hash in lower-caps to image metadata.

I recommend adjusting the search term comparison so that case-sensitivity is not a factor.

@RupertAvery
Copy link
Owner

Thank you. The fix will be included in the next release

@RupertAvery RupertAvery self-assigned this Jul 28, 2023
@RupertAvery RupertAvery added the bug Something isn't working label Jul 28, 2023
RupertAvery added a commit that referenced this issue Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants