Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rust: add a note about rustup override set #896

Merged
merged 1 commit into from
Sep 30, 2022
Merged

docs: rust: add a note about rustup override set #896

merged 1 commit into from
Sep 30, 2022

Conversation

masahir0y
Copy link

No description provided.

@masahir0y
docs: rust: add a note about rustup override set
f2238e7 
This is just FWIW, but O= changes the working directory before the
build starts.

If you do 'rustup override set' in the source tree and O= points a
directory outside, the version override is not effective.

For example,

  $ rustup override set $(scripts/min-tool-version.sh rustc)
  $ make LLVM=1 O=../build-dir

RUSTUP_TOOLCHAIN works irrespective of the working directory. Anyway,
people will eventually find a way they like.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
adamrk
adamrk approved these changes Sep 29, 2022
View reviewed changes
Copy link

@adamrk adamrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ojeda
Copy link
Member

ojeda commented Sep 30, 2022

Thanks! Good point, it can be confusing.

@ojeda ojeda merged commit 5423795 into Rust-for-Linux:rust Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrk adamrk adamrk approved these changes

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masahir0y @ojeda @adamrk @bjorn3