Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing AEAD marker traits and generic constructions #564

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rlee287
Copy link

@rlee287 rlee287 commented Oct 31, 2023

This is a successor to the PR RustCrypto/traits#1365.

Notes for the future as to schemes I chose not to implement:

  • Appending a hash of the key to the tag: This scheme would provide key-commitment security, but it has catastrophic interactions with the naive key rotation scheme of replacing a key by hashing the existing one.
  • CTX+: An attacker that obtains the inner tag of a ciphertext may be able to perform a length extension attack by extending the AAD to forge a new tag. (Admittedly, this is an unlikely attack scenario, but this consideration was what led me to create CTXish-HMAC instead of a CTX+ish-HMAC.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant