Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do dotnet tool restore automatically in build target #613

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

theprash
Copy link
Member

@theprash theprash commented Jun 7, 2024

By adding a target in Build.fsproj to run dotnet tool restore, we can remove the step that requires users to do it manually.

Should we go ahead with this? Discussion welcome.

Copy link
Member

@mattgallagher92 mattgallagher92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

It'll add a very small amount of time on every build, but I think that the benefits (better experience for new devs; automatic tool restore when switching branches) are worth it 😀

@mattgallagher92
Copy link
Member

We likely want to update the docs site too.

@mattgallagher92
Copy link
Member

Maybe we want to change the root level Build.fsproj to be consistent?

@Larocceau
Copy link
Contributor

@mattgallagher92 also added the automatic restore to the root level build.fsproj. I think we can merge this?

@Larocceau Larocceau marked this pull request as ready for review June 14, 2024 14:22
@Larocceau Larocceau merged commit d6ce051 into master Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants