Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include the core plugin files on the login page #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gthayer
Copy link

@gthayer gthayer commented May 9, 2022

Issue: #129

Fixes the missing function error by including the WordPress core functions. I am not clear why newer versions of WP are breaking, but the root of the issue comes down to the plugin firing the is_plugin_active function before WordPress has loaded it.

@Exordian
Copy link

ping @pitbulk
i hope it's fine to ping you. it would be awesome if you fine some minutes to review the open PRs including this one. the plugin works super fine for us. yet, we hope it does still work in the future (with more recent wordpress versions), hence taking a look on this would be very much appreciated

@sandykadam
Copy link

Yes please merge this PR, we need this fix for upgraded version where it is breaking.

@pitbulk
Copy link
Contributor

pitbulk commented Aug 26, 2022

Im trying to get privileges again on this and rest of SAML repos

@tomasvanagas
Copy link

Any progress on this?

@mrmoss
Copy link

mrmoss commented Oct 13, 2022

@tomasvanagas - Still working on getting @pitbulk access. I wish I had a better answer 😞

@pitbulk
Copy link
Contributor

pitbulk commented May 22, 2023

@mrmoss any progress giving me access to WP plugin at Github and Wordpress site?

@michael-sumner
Copy link

I've filed a similar PR to address where the function does not need to exist and instead relies on the active_plugins option:

This fixes the issue with:

PHP message: PHP Fatal error:  Uncaught Error: Call to undefined function is_plugin_active() in /code/wp-content/plugins/onelogin-saml-sso/php/functions.php:108

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants