Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(defaults): Download defaults file from github release" #175

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

CCFenner
Copy link
Member

@CCFenner CCFenner commented Feb 20, 2024

Reverts #174 due to GH API rate limit breaches with GH com.

@CCFenner CCFenner merged commit 28caec7 into main Feb 20, 2024
13 of 14 checks passed
@CCFenner CCFenner deleted the revert-174-defaults_from_release branch February 20, 2024 14:28
CCFenner added a commit that referenced this pull request Feb 23, 2024
CCFenner added a commit that referenced this pull request Mar 15, 2024
* Revert "Revert "feat(defaults): Download defaults file from github release" (#175)"

This reverts commit 28caec7.

* revert some changes

* make diff readable

* changes

* update generated sources

* add debug statement

* fix url

* add debug messages

* add fallback

* adjust test cases

* fix unit tests for OS binary download

* update dist

* fix lint issues

* update node version

* improve debug output

* update dist

---------

Co-authored-by: Gulom Alimov <gulomjon.alimov@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant