Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info to breaking change bot about need for manual check for @spartacus/core #4609

Closed
marlass opened this issue Sep 17, 2019 · 0 comments · Fixed by #4610
Closed

Add info to breaking change bot about need for manual check for @spartacus/core #4609

marlass opened this issue Sep 17, 2019 · 0 comments · Fixed by #4610
Milestone
1.2.1

Comments

@marlass
Copy link
Contributor

marlass commented Sep 17, 2019

There is an issue in api-extractor : microsoft/rushstack#1029

Core uses those exports, so it can't be analyzed with extractor.
Provide message about this and inform about need for manual check.
@marlass marlass self-assigned this Sep 17, 2019
@marlass marlass mentioned this issue Sep 17, 2019
Merged
marlass added a commit that referenced this issue Sep 17, 2019
@marlass
Merge branch 'develop' into feature/GH-4609
ce2f472
marlass added a commit that referenced this issue Sep 18, 2019
@marlass
chore: Improve bot with warning about core lib (#4610)
a965b00 
Closes #4609
@marlass marlass removed their assignment Sep 18, 2019
@Xymmer Xymmer added this to the 1.2.1 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

chore: Improve bot with warning about core lib SAP/spartacus
2 participants
@Xymmer @marlass