Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DynamicPage]: the width style of header content div is not correct #6135

Closed
1 task done
GongRichard opened this issue Jul 29, 2024 · 5 comments · Fixed by #6163
Closed
1 task done

[DynamicPage]: the width style of header content div is not correct #6135

GongRichard opened this issue Jul 29, 2024 · 5 comments · Fixed by #6163
Labels
bug Something isn't working released SAP SF

Comments

@GongRichard
Copy link

GongRichard commented Jul 29, 2024

Describe the bug

please don't set width 100% to the head content div of DynamicPage

Isolated Example

No response

Reproduction steps

  1. open page https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-dynamicpage--docs
  2. open dev tool to check the width of head content div
  3. you will find the div width of head content div is not correct

Expected Behaviour

remove width 100% setting

Screenshots or Videos

image

UI5 Web Components for React Version

1.29.5

UI5 Web Components Version

1.24.x

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SAP SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@GongRichard GongRichard added the bug Something isn't working label Jul 29, 2024
@Lukas742 Lukas742 linked a pull request Aug 5, 2024 that will close this issue
Lukas742 added a commit that referenced this issue Aug 5, 2024
@Lukas742 Lukas742 closed this as completed Aug 5, 2024
@Lukas742 Lukas742 added the SAP SF label Aug 5, 2024
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.29.6 🎉

The release is available on v1.29.6

Your semantic-release bot 📦🚀

@sebastian-kraemer
Copy link

@Lukas742
Isn't this breaking the fix for the other issue: #6087

@Lukas742
Copy link
Contributor

Lukas742 commented Aug 7, 2024

Hi @sebastian-kraemer

you're totally right, for some reason I didn't see that when looking at the GitHub change history for this line and thought it was a remnant of our v2 refactoring. Thanks a lot for noticing!
I will investigate how this can be fixed for both scenarios and publish another version then.

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.29.7 🎉

The release is available on v1.29.7

Your semantic-release bot 📦🚀

@Lukas742
Copy link
Contributor

Lukas742 commented Aug 7, 2024

Hi @sebastian-kraemer

now the scrolling should work as intended again and also the header shouldn't overflow anymore. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released SAP SF
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

4 participants