Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device/alibaba]: Update platform util follow bmc hal api #133

Conversation

mudsut4ke
Copy link

- What I did

  • Update platform util follow bmc hal api (Phalanx)

- How I did it

- How to verify it

@mudsut4ke
Copy link
Author

@tiantianlv @xwang9 ,

I can't run a testing on Fishbone unit, Is that BMC debug version compatible with Fishbone unit ?

I try to install new BMC (flash-obmc-cl) on Fishbone48 (10.204.112.71 6202) after installing finished and rebooted I found an error

Screenshot from 2020-02-03 18-51-12

So I didn't included Fishbone platform code in this PR

@tiantianlv
Copy link

tiantianlv commented Feb 3, 2020 via email

@mudsut4ke
Copy link
Author

Hi Micky/Victor, Can you send your new version to Wirut for testing. Thanks, Bo

On Mon, Feb 3, 2020 at 7:58 PM Wirut Getbamrung @.***> wrote: @tiantianlv https://github.com/tiantianlv @xwang9 https://github.com/xwang9 , I can't run a testing on Fishbone unit, Is that BMC debug version compatible with Fishbone unit ? I try to install new BMC (flash-obmc-cl) on Fishbone48 (10.204.112.71 6202) after installing finished and rebooted I found an error [image: Screenshot from 2020-02-03 18-51-12] https://user-images.githubusercontent.com/22809903/73651098-455df880-46b6-11ea-82a7-a67b3c07ca9a.png So I didn't included Fishbone platform code in this PR — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#133?email_source=notifications&email_token=AJH2ZBA3CZBMZE4YUJFK253RBABH3A5CNFSM4KPDZTB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKTSSUA#issuecomment-581380432>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJH2ZBDILPKKFHI7LTPB66TRBABH3ANCNFSM4KPDZTBQ .
-- Best Regards Bo Lv Celestica SAE-Product 86-21-61006028-7722 bolv@celestica.com evhuang@celestica.com www.celestica.com https://www.google.com/url?q=http://www.celestica.com&sa=D&source=hangouts&ust=1563962866674000&usg=AFQjCNEf1yNh8FqX0NMUIH6XFiJ1SQBOPA

@MickeyZhan

Copy link

@xwang9 xwang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the code more simple that before, it's a good practice, Approve.

@mudsut4ke mudsut4ke changed the base branch from 201811_cel to 201811_cel_dev_for_openbmc March 13, 2020 07:09
@mudsut4ke mudsut4ke force-pushed the Ali-upgrade-platformutil-0.2 branch 3 times, most recently from 4f0912e to 1a82bed Compare March 17, 2020 07:30
@mudsut4ke mudsut4ke force-pushed the Ali-upgrade-platformutil-0.2 branch from 78c88b9 to dd7a74e Compare March 17, 2020 08:08
@mudsut4ke mudsut4ke requested a review from xwang9 March 17, 2020 08:29
@mudsut4ke mudsut4ke merged commit a4fe672 into SONIC-DEV:201811_cel_dev_for_openbmc Mar 17, 2020
mudsut4ke pushed a commit that referenced this pull request Jan 25, 2021
* src/sonic-snmpagent 89b7b2c...c702a57 (7):
  > Revert "[rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#133)" (#151)
  > Update transceiver info DB key names (#146)
  > Fix LGTM reported alert of PR#141 (#142)
  > [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (#141)
  > [Namespace]: Fix SNMP AgentX  socket connection timeout when using Namespace.get_all()  (#140)
  > [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#133)
  > Fix undefined variable and warning message (#134)

* src/sonic-py-swsssdk a83366e...2df4f40 (3):
  > Allowing TCP connections with namespace as well. (#81)
  > [port_util] add get_rif_port_map, get_vlan_interface_oid_map (#78)
  > Updates to the namespace API's for test_moduleLoad.py (#77)

Note that sonic-snmpagent submodule update is dependent upon sonic-py-swsssdk update, so updating both submodules in this PR.
mudsut4ke pushed a commit that referenced this pull request Jan 25, 2021
Includes the following commits:

* src/sonic-platform-common 111dcf7...b316f8d (5):
  > [sonic_platform_base] fix an indentation in fan_drawer_base.py (#133)
  > [SONIC_Y_CABLE] Adding new Y cable Package for accessing  Y cable QSFP's eeprom and configuring Y cable's mux through eeprom (#128)
  > Merge pull request #132 from vdahiya12/adding_changes_for_base_api
  > [ChassisBase][ModuleBase] Remove redundant 'get_serial_number()' method (#130)
  > Merge pull request #125 from vdahiya12/changes_for_mux_driver
mudsut4ke pushed a commit that referenced this pull request Jan 25, 2021
This PR updates the following commits in master for
sonic-platform-daemons

b0be7ca [xcvrd] add unit test infrastructure and unit tests for xcvrd (#133)
8555077 [xcvrd] removing the delete notification message logic for command probe in mux cable driver (#134)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants